Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(notification): component used by composition , and add notification recycle effect #429

Merged
merged 16 commits into from
Mar 15, 2022
Merged

refactor(notification): component used by composition , and add notification recycle effect #429

merged 16 commits into from
Mar 15, 2022

Conversation

qunbotop
Copy link
Contributor

🤔 这个 PR 的性质是？

  1. 使用vue3 composition API重构notification和notificationList组件
  2. 使用transition-group完善notification回收时的动画效果

🔗 相关 Issue

#58

💡 需求背景和解决方案

  1. 将methods、computed写入setup函数中，使用useEmitEvent替换emitEvent。
  2. 先前的notification只有出现时的动画，回收时直接消失。重构时使用了transition-group包裹notificationList组件，并将之前四个方向的样式进行了提取，封装成slide-fade函数。

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档无须补充
  • 代码演示无须提供
  • TypeScript 定义无须补充
  • Changelog 无须提供

@qunbotop
refactor: refactor notification component used by composition
ae2e792 
BREAKING CHANGE: refactor notification component used by composition , and add notification recycle
effect
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2022 •
edited
Loading

完成

PengYYYYY
PengYYYYY reviewed Mar 11, 2022
View reviewed changes
@PengYYYYY PengYYYYY mentioned this pull request Mar 13, 2022
Closed
PengYYYYY
PengYYYYY reviewed Mar 15, 2022
View reviewed changes
@PengYYYYY PengYYYYY mentioned this pull request Mar 15, 2022
Closed
52 tasks
@PengYYYYY PengYYYYY merged commit 8cb0b27 into Tencent:compositionAPI Mar 15, 2022
@qunbotop qunbotop changed the title refactor: refactor notification component used by composition , and add notification recycle effect refactor(notification): component used by composition , and add notification recycle effect May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qunbotop @PengYYYYY