fix(image-viewer): download img with params the file ext is lost #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uyarn
reviewed
Jun 3, 2023
uyarn
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#2395
💡 需求背景和解决方案
1、问题
链接带参数时（?或#），扩展名失效
2、处理方案
做?和#的字符串分割，取无参数的部分再进行/分割，拿到最后的原文件名，再进行下载
📝 更新日志
fix(ImageViewer): 修复图片链接带有参数时，下载时文件扩展名丢失 (issue #2935)
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单