-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(unit): input: add input test #1764
Conversation
input: add input test
|
好的,
发自我的iPhone
…------------------ Original ------------------
From: PY ***@***.***>
Date: Wed,Sep 28,2022 7:14 PM
To: Tencent/tdesign-vue-next ***@***.***>
Cc: luopei ***@***.***>, Author ***@***.***>
Subject: Re: [Tencent/tdesign-vue-next] test(unit): input: add input test (PR#1764)
reabse 一下develope, vue 发了一个3.2.40的版本,server-render 下面输出的 html 中,svg 中的 viewbox 变更到 viewBox,develope 分支中已修复
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
maxcharacter 那里没有用String处理,不用转换
…------------------ 原始邮件 ------------------
发件人: ***@***.***>;
发送时间: 2022年9月29日(星期四) 下午2:06
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [Tencent/tdesign-vue-next] test(unit): input: add input test (PR #1764)
@PengYYYYY commented on this pull request.
In src/input/useInput.ts:
> - const stringInfo = getCharacterLength(val, props.maxcharacter); - if (typeof stringInfo === 'object') { - if (!props.allowInputOverMax) { - val = stringInfo.characters; - } - limitNumber.value = `${stringInfo.length}/${props.maxcharacter}`; - } - } - if (props.maxlength && props.maxlength > 0) { - if (!props.allowInputOverMax) { - val = val.substring(0, props.maxlength); - } - limitNumber.value = `${val.length}/${props.maxlength}`; - } + const val = (target as HTMLInputElement).value; + // if (props.maxcharacter && props.maxcharacter > 0) {
这一段 对maxcharacter 直接删掉吗?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
代码不用注释了,没用的话直接删掉 |
好,等下我再看一下
…------------------ 原始邮件 ------------------
发件人: "Tencent/tdesign-vue-next" ***@***.***>;
发送时间: 2022年9月29日(星期四) 下午2:58
***@***.***>;
***@***.******@***.***>;
主题: Re: [Tencent/tdesign-vue-next] test(unit): input: add input test (PR #1764)
maxcharacter 那里没有用String处理,不用转换
…
------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2022年9月29日(星期四) 下午2:06 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [Tencent/tdesign-vue-next] test(unit): input: add input test (PR #1764) @PengYYYYY commented on this pull request. In src/input/useInput.ts: > - const stringInfo = getCharacterLength(val, props.maxcharacter); - if (typeof stringInfo === 'object') { - if (!props.allowInputOverMax) { - val = stringInfo.characters; - } - limitNumber.value = ${stringInfo.length}/${props.maxcharacter}; - } - } - if (props.maxlength && props.maxlength > 0) { - if (!props.allowInputOverMax) { - val = val.substring(0, props.maxlength); - } - limitNumber.value = ${val.length}/${props.maxlength}; - } + const val = (target as HTMLInputElement).value; + // if (props.maxcharacter && props.maxcharacter > 0) { 这一段 对maxcharacter 直接删掉吗? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
代码不用注释了,没用的话直接删掉
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@PengYYYYY 已经修改了哈,保证测试通过 |
input: add input test
🤔 这个 PR 的性质是?
🔗 相关 Issue
#768
💡 需求背景和解决方案
新增组件单元测试
📝 更新日志
input
单元测试☑️ 请求合并前的自查清单