Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): 修复 Input 组件 切换 type 后不生效的问题 #1183

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix(input): 修复 Input 组件 切换 type 后不生效的问题 #1183

merged 1 commit into from
Jul 12, 2022

Conversation

hi-zhaoyeqing
Copy link
Contributor

@hi-zhaoyeqing hi-zhaoyeqing commented Jul 9, 2022 •
edited by PengYYYYY
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 修复 Input 组件 切换 type 后不生效的问题，官网 Input 中组件示例 选择 type 切换时 Input 中的 type 不会变化。
  2. 添加 watch
  3. 复现地址：https://tdesign.tencent.com/vue-next/components/input 示例中切换 type 即可复现

📝 更新日志

  • fix(Input): 修复 Input 组件切换 type 后不生效的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@timi137137
Copy link
Contributor

image
这是什么

@timi137137
Copy link
Contributor

image
这又是什么

@timi137137
Copy link
Contributor

image
而且你vue的组件你为什么会在vue3的组件库修复

timi137137
timi137137 suggested changes Jul 9, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022 •
edited
Loading

完成

PengYYYYY
PengYYYYY reviewed Jul 10, 2022
View reviewed changes
@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/input-type-change branch 2 times, most recently from be8e148 to 2b23a87 Compare July 10, 2022 08:59
PengYYYYY
PengYYYYY reviewed Jul 10, 2022
View reviewed changes
@hi-zhaoyeqing
fix(input): 修复 Input 组件 切换 type 后不生效的问题
9846fe9 
修复 Input 组件 切换 type 后不生效的问题
@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/input-type-change branch from 2b23a87 to 9846fe9 Compare July 11, 2022 12:02
@PengYYYYY PengYYYYY merged commit a420e98 into Tencent:develop Jul 12, 2022
hi-zhaoyeqing added a commit to hi-zhaoyeqing/tdesign-vue-next that referenced this pull request Jul 12, 2022
@hi-zhaoyeqing
fix(input): 修复 Input 组件 切换 type 后不生效的问题 (Tencent#1183)
b435eb0 
修复 Input 组件 切换 type 后不生效的问题
@github-actions github-actions bot mentioned this pull request Jul 14, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

@timi137137 timi137137 timi137137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hi-zhaoyeqing @timi137137 @PengYYYYY