-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(timepicker): 修复边界滚动异常问题 #1425
Conversation
看起来还需要配合common的before after改动才可以修复 你看看能把common切到你的commit上 并先在解决方案里写下处理方式吗 |
Codecov Report
@@ Coverage Diff @@
## develop #1425 +/- ##
===========================================
+ Coverage 61.00% 62.86% +1.86%
===========================================
Files 1030 1030
Lines 17933 17904 -29
Branches 4121 4089 -32
===========================================
+ Hits 10940 11256 +316
+ Misses 6993 6648 -345
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@uyarn 现在的方案是,通过调整 before after 的高度,让滚动到顶部(或底部)的时候是自然的,不需要再反方向调整。 临时将 common 的代码加到我的分支上了,可以用 preview 链接看看,没问题我再更新这个 pr。 |
看起来效果很ok 👍🏻 我去看看common的代码 没有问题合并之后你checkout下submodule回主干 |
@HelKyle common Pull Request Tencent/tdesign-common#802 has been merged |
fdb6cd9
to
23d0e74
Compare
重新提了 pr #1426 |
fix: Tencent/tdesign-vue-next#1012
关联子仓库:Tencent/tdesign-common#802
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(TimePicker): 修复边界滚动问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单