Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): 修复 onClosed 事件回调 #1368

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

HelKyle
Copy link
Contributor

@HelKyle HelKyle commented Aug 25, 2022

fix #1333

🤔 这个 PR 的性质是?

  • [] 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1333

💡 需求背景和解决方案

📝 更新日志

  • fix(Alert): 增加关闭动画 && 修复 onClosed 回调事件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

完成

@honkinglin
Copy link
Collaborator

image

删除的时候会有警告得处理下

@codecov-commenter
Copy link

Codecov Report

Merging #1368 (8349588) into develop (c670862) will increase coverage by 1.05%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
+ Coverage    59.94%   61.00%   +1.05%     
===========================================
  Files         1017     1030      +13     
  Lines        17837    17939     +102     
  Branches      4088     4124      +36     
===========================================
+ Hits         10693    10944     +251     
+ Misses        7144     6995     -149     
Impacted Files Coverage Δ
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/alert/Alert.tsx 97.67% <100.00%> (+0.11%) ⬆️
src/form/_example/base.jsx 50.00% <0.00%> (-3.85%) ⬇️
src/select/base/PopupContent.tsx 90.00% <0.00%> (-2.31%) ⬇️
src/popup/Popup.tsx 92.30% <0.00%> (ø)
src/form/FormItem.tsx 83.33% <0.00%> (ø)
src/_util/renderTNode.ts 75.00% <0.00%> (ø)
src/form/FormContext.tsx 100.00% <0.00%> (ø)
src/form/useInitialData.ts 100.00% <0.00%> (ø)
src/form/_example/error-message.jsx 56.00% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@honkinglin
Copy link
Collaborator

LGTM

@honkinglin honkinglin merged commit ad3129c into Tencent:develop Aug 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 29, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert 警告] 试了2种写法,onClosed 都没效果
3 participants