Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): 修复 tree-select 首次渲染出现 key 为 undefined 的问题 #1332

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

HelKyle
Copy link
Contributor

@HelKyle HelKyle commented Aug 19, 2022

fix #1330

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1330

💡 需求背景和解决方案

📝 更新日志

  • fix(Table): 修复 tree-select 首次渲染出现 key 为 undefined 的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

完成

@honkinglin
Copy link
Collaborator

测试没有过,更新下snapshot
npm run test:update

@HelKyle
Copy link
Contributor Author

HelKyle commented Aug 25, 2022

测试没有过,更新下snapshot npm run test:update

已更新

@codecov-commenter
Copy link

Codecov Report

Merging #1332 (e07b5c6) into develop (3eae14b) will increase coverage by 1.12%.
The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           develop    #1332      +/-   ##
===========================================
+ Coverage    59.88%   61.00%   +1.12%     
===========================================
  Files         1017     1030      +13     
  Lines        17807    17935     +128     
  Branches      4085     4125      +40     
===========================================
+ Hits         10663    10942     +279     
+ Misses        7144     6993     -151     
Impacted Files Coverage Δ
src/_util/helper.ts 21.62% <ø> (-19.45%) ⬇️
src/config-provider/_example/global.jsx 100.00% <ø> (ø)
src/date-picker/hooks/useRange.tsx 37.66% <ø> (+0.48%) ⬆️
src/date-picker/hooks/useSingle.tsx 40.74% <ø> (+0.74%) ⬆️
src/form/formModel.ts 57.44% <ø> (ø)
src/input/Input.tsx 87.50% <ø> (+0.19%) ⬆️
src/message/Message.tsx 17.10% <ø> (ø)
src/select/_example/panel.jsx 47.61% <0.00%> (ø)
src/table/PrimaryTable.tsx 93.33% <ø> (+0.15%) ⬆️
src/textarea/_example/type.jsx 100.00% <ø> (ø)
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@honkinglin honkinglin merged commit 14b065f into Tencent:develop Aug 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 29, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] EnhancedTable报Warning: Each child in a list should have a unique "key" prop.
4 participants