feat(button): add props tId & add event bindagreeprivacyauthori… #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeJim
requested changes
Aug 25, 2023
src/button/README.en-US.md
Outdated
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| name | type | default | description | required | |||
| -- | -- | -- | -- | -- | |||
| buttonId | String | - | button tag id | N | |||
There was a problem hiding this comment.
使用id作为键值是不会被props所引用的。如考虑通用性，此处可改用其它名称。
There was a problem hiding this comment.
id 更合适
已修改button-id为t-id， 形式参照t-class
LeeJim
approved these changes
Aug 29, 2023
|
fixed by #2330 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(Button): 新增
t-id属性，相等于idfeat(Button): 属性 open-type 新增支持
agreePrivacyAuthorization本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单