-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Button): support 0.5px border by transform property #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -1 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
523cee6
to
6bafed1
Compare
Size Change: -1 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
Size Change: -187 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
77e74aa
to
9dad942
Compare
Size Change: -1 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
9dad942
to
1aa9254
Compare
Size Change: -1 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
1aa9254
to
6323f57
Compare
Size Change: +2 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
This was referenced Jan 11, 2023
Closed
Closed
LeeJim
reviewed
Jan 11, 2023
Size Change: +71 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
LeeJim
approved these changes
Jan 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #1318 补充问题,修复示例文案错误
fix #1329 补充问题,修复 border-bottom-width 错误
fix #1475
💡 需求背景和解决方案
📝 更新日志
说明: button 组件边框基于 定位+伪元素+scale(.5) 实现,若要实现 border-width 为 0.5px , 可使用css variable实现,令
--td-button-border-width: 1px
feat(Button): 支持 0.5px 边框
fix(Dialog): 修复 confirmBtn 为 string 类型时,样式错误
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单