fix(switch): 修复朗读不可用问题. (#1018) #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa1b90 to
fca42a8
Compare
|
录屏00:08，”带描述开关“当开关状态是为“关”时，会播报出“关”这个信息，但处于”开“时却不播报；建议：要么”开“和”关“这2个关键词都能播报，要么都省略不播报（能正确传达”已/未勾选“信息即可） |
syxysszyw
reviewed
Nov 30, 2022
| @@ -49,6 +49,7 @@ | |||
| .@{prefix}-switch { | |||
| display: flex; | |||
| align-items: center; | |||
| overflow: hidden; | |||
|
现在的录屏没有将整个示例录完，辛苦 @byq1213 提供一个完整的录屏链接 |
|
从语义化的角度来讲，示例这里是不是在t-switch外层包一个label会更标准些？ |
完整演示: https://share.weiyun.com/rys6kBFw |
syxysszyw
reviewed
Nov 30, 2022
| disabled="{{disabled}}" | ||
| aria-checked="{{checked}}" | ||
| aria-disabled="{{disabled}}" | ||
| aria-role="checkbox" |
There was a problem hiding this comment.
为什么是在label上设计aria-role=checkbox呀？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#1018
💡 需求背景和解决方案
📝 更新日志
☑️ 请求合并前的自查清单
演示链接:
https://share.weiyun.com/KbBwx0E0