Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tree-setdata-interception-parameters #645

Conversation

zhangpaopao0609
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

Tencent/tdesign-vue-next#1205

💡 需求背景和解决方案

  1. 需求背景
    使用 node.setData 时,传入错误的参数可能会导致程序崩溃。

  2. 优化方案
    在尽量少改动的前提下,可以在 setData 做一层拦截,至少避免因传参错误导致程序崩溃

📝 更新日志

  • fix(tree): setData interception parameters

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Collaborator

@PengYYYYY PengYYYYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PengYYYYY PengYYYYY merged commit 4433847 into Tencent:develop Jul 16, 2022
PengYYYYY added a commit that referenced this pull request Jul 18, 2022
uyarn pushed a commit that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants