Implemented theme days for tAngled 22/23 #21
Conversation
|
|
||
| // TODO: Change this according to the different theme days | ||
| // FORMAT: [dayNum, monthNum] | ||
| ctx.themeDays = [[27, 8], [28, 8], [29, 8], [30, 8], [31, 8], [1, 9]] |
There was a problem hiding this comment.
Could we put this as a json in the env file or in a config.js file? We shouldn't include magic constants in logic files
| if (!ctx.isRegistered) { | ||
| return ctx.reply(messages.NotRegistered) | ||
| } | ||
| var person = ctx.person |
There was a problem hiding this comment.
Is there a reason for this to be var instead of const? It might be even better to inline this
| return ctx.reply(messages.NotRegistered) | ||
| } | ||
| var person = ctx.person | ||
| if (person.confirm) { |
There was a problem hiding this comment.
If i'm understanding your intention correctly (boolean var for today's theme), I would instead name this ctx.person.confirmedToday
- change variable name to be more informative
- inlined ctx
| person.confirm = true | ||
| model.saveToStorage() | ||
|
|
||
| const other = ctx.isAngel ? ctx.angel : ctx.mortal |
There was a problem hiding this comment.
I think this is already done by middleware? (So it should be available as a field of ctx) If not, we could put this into middleware
| @@ -40,6 +42,10 @@ async function start(model) { | |||
| bot.on('message', Commands.MessageHandler) | |||
| //TODO: handle sending files | |||
| bot.launch().then(() => console.log(bot._name + " started")).catch(console.error) | |||
|
|
|||
| // Enable graceful stop | |||
| process.once('SIGINT', () => bot.stop('SIGINT')); | |||
There was a problem hiding this comment.
Could separate this out into another PR, cos this would be good in main branch but we may not want to include the tangles specific stuff
| } | ||
| // Cell contains fun fact about the person | ||
| if (colNumber > 2 && colNumber < 8) { | ||
| angel.facts.push(cell.value) |
There was a problem hiding this comment.
this implicitly assumes the eachCell iteration order. It would be better defensive programming to construct the person with a fixed size array, then index that array based on colNumber
No description provided.