chore(eslint): use common config #382
Conversation
| const page = await openStoryPage({ | ||
| id: 'components-forms-select--default', | ||
| device, | ||
| userAgent, |
There was a problem hiding this comment.
unrelated. This was a TS error. I think CI doesn't check TS on test files
There was a problem hiding this comment.
hmm, I added a yarn ts-check in the ci target... it should check types in jenkins (at least in master)
| @@ -4,7 +4,7 @@ import Popover from '../popover'; | |||
| import {ThemeContextProvider} from '..'; | |||
| import {makeTheme} from './test-utils'; | |||
|
|
|||
| type Props = Omit<React.ComponentProps<typeof Popover>, 'children' | 'description' | 'target'>; | |||
src/list.tsx
Outdated
| @@ -246,6 +246,7 @@ interface SwitchRowContentProps extends CommonProps { | |||
| checkbox?: undefined; | |||
| radioValue?: undefined; | |||
| newTab?: undefined; | |||
| fullPageOnWebView?: undefined; | |||
There was a problem hiding this comment.
this fixes a TS error in list-type-test.tsx
| interface FontFace extends FontFaceDescriptors { | ||
| new (family: string, source: string | ArrayBuffer, descriptors?: FontFaceDescriptors): FontFace; | ||
| class FontFace extends FontFaceDescriptors { | ||
| constructor( |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit d8dc561. |
|
Accessibility report ℹ️ You can run this locally by executing |
package.json
Outdated
| @@ -76,6 +76,7 @@ | |||
| "@swc/core": "^1.2.93", | |||
| "@swc/jest": "^0.2.4", | |||
| "@telefonica/acceptance-testing": "^2.5.0", | |||
| "@telefonica/eslint-config": "^1.0.0-beta5", | |||
There was a problem hiding this comment.
Pending on non-beta release: https://github.com/Telefonica/js-toolbox/pull/21
|
welcome story is broken🤭 https://mistica-web-fqpjoiea1-tuentisre.vercel.app/?path=/story/welcome-welcome--mistica |
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable filenames/match-regex */ | |||
There was a problem hiding this comment.
perhaps the rule could allow any *.config.js files
| "transform": { | ||
| "react": { | ||
| "runtime": "automatic" | ||
| } | ||
| } |
There was a problem hiding this comment.
this fixes the welcome story
Fixed |
|
🎉 This PR is included in version 10.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Telefonica/js-toolbox#21