Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add label property to simple-block #1308

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: add label property to simple-block #1308

merged 5 commits into from
Jan 15, 2025

Conversation

wendellguimaraes-tlf
Copy link
Contributor

@wendellguimaraes-tlf wendellguimaraes-tlf commented Jan 8, 2025 •
edited
Loading

OBVIVO-2814 (Simple Block): the label property was added to the simple block, and some adjustments were also included using the Inline component to align the position in the component.

https://www.figma.com/design/hTthBYJeDVzcpUhkQYlyFG/Blocks-specs?node-id=7304-2609&t=GTbvRZkMvRSJacnI-0

@wendellguimaraes-tlf
OBVIVO-2814 (Simple Block): the label property was added to the simpl…
d52e2f0 
…e block, and some adjustments were also included using the Inline component to align the position in the component
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Size stats

master this branch diff
Total JS 12.3 MB 12.3 MB +591 B
JS without icons 2.05 MB 2.05 MB +591 B
Lib overhead 72.8 kB 72.8 kB 0 B
Lib overhead (gzip) 17.1 kB 17.1 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-6vzrp3xo1-flows-projects-65bb050e.vercel.app

Built with commit f0349e9.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Screenshot tests report

✔️ All passing

yceballost
yceballost approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Just a little detail, add the prop label to playroom snippets

mistica-web/playroom/snippets.tsx

Lines 3957 to 3970 in 34bcc78

const SimpleBlockSnippets = [
{
name: 'Simple Block',
code: `
<SimpleBlock
image={
<Image src="${imagePlaceholder}" height={40} />
}
description="description"
/>
`,
group: 'Blocks',
},
];

@wendellguimaraes-tlf
Copy link
Contributor Author

Perfeito!

Só um pequeno detalhe, adicione o adereço labelaos trechos da sala de jogos

mistica-web/playroom/snippets.tsx

Lines 3957 to 3970 in 34bcc78

const SimpleBlockSnippets = [
{
name: 'Simple Block',
code: `
<SimpleBlock
image={
<Image src="${imagePlaceholder}" height={40} />
}
description="description"
/>
`,
group: 'Blocks',
},
];

Done !

@atabel atabel added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 2c57982 Jan 15, 2025
11 checks passed
@atabel atabel deleted the OBVIVO-2814 branch January 15, 2025 16:52
tuentisre pushed a commit that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore(release): 16.9.0 [skip ci]
fbc4e89 
# [16.9.0](v16.8.0...v16.9.0) (2025-01-28)

### Features

* add label property to simple-block ([#1308](#1308)) ([2c57982](2c57982))
* **Form:** Disable autofocus on error for some fields on iOS ([#1307](#1307)) ([316565d](316565d))
* **icons:** New artificial intelligence and my handy icons ([#1310](#1310)) ([433db7c](433db7c))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atabel atabel atabel approved these changes

@yceballost yceballost yceballost approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wendellguimaraes-tlf @tuentisre @atabel @yceballost