feat(PhoneNumberFieldLite): Phone number field with simple formatting to reduce bundle size #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 12:49
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit b19a407. |
pladaria
commented
Oct 22, 2024
| const rifm = useRifm({ | ||
| format, | ||
| value: controlledValue, | ||
| accept: /[\d\+]+/g, |
There was a problem hiding this comment.
@marcoskolodny the issues we saw in the custom formatter example and the + char were caused because it wasn't added in the accept regex
atabel
approved these changes
Oct 23, 2024
added 2 commits
October 28, 2024 18:48
marcoskolodny
approved these changes
Oct 28, 2024
atabel
approved these changes
Oct 29, 2024
tuentisre
pushed a commit
that referenced
this pull request
Nov 4, 2024
# [16.4.0](v16.3.1...v16.4.0) (2024-11-04) ### Bug Fixes * **TextField:** adjust position of maxLength's screen reader label ([#1283](#1283)) ([fda424e](fda424e)) * **TextField:** avoid right helper text from wrapping, fix spacing and aria label for maxCount text when multiline is true ([#1272](#1272)) ([85fcb31](85fcb31)) * **useDisableBodyScroll:** avoid affecting body's height ([#1279](#1279)) ([b68f317](b68f317)) ### Features * **PhoneNumberFieldLite:** Phone number field with simple formatting to reduce bundle size ([#1276](#1276)) ([a141b97](a141b97)) * **Row:** allow aria-label in informative rows ([#1269](#1269)) ([65b5d42](65b5d42)) * **Rows, Cards, FeedbackScreen, FormFields, Buttons:** add test ids for components and their internal elements ([#1270](#1270)) ([fc63201](fc63201)) * **Spinner:** improve a11y ([#1274](#1274)) ([5267ad5](5267ad5)) * **Switch, RadioButton, Checkbox, ProgressBar, ProgressBarStepped, Slider:** create inverse variant ([#1277](#1277)) ([3129fb9](3129fb9))
|
🎉 This PR is included in version 16.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-2081
Review re-requested because E164 support has been added
Related commits:
https://github.com/Telefonica/mistica-web/pull/1276/files/59f3ec30947f358fddff18befe4e1db69726fb4d..7cb3c6f1eef8445bba2b247d1f246b2fba9c904e