chore(dependencies): upgrade dependencies #1147

pladaria · 2024-06-11T13:23:54Z

Upgraded:

prettier
eslint
acceptance-testing
react-testing-library & co
typescript
vanilla extract
playroom (as requested by @yceballost )

github-actions · 2024-06-11T13:25:54Z

Size stats

	master	this branch	diff
Total JS	11.9 MB	11.9 MB	+1.94 kB
JS without icons	1.97 MB	1.97 MB	+1.94 kB
Lib overhead	54.2 kB	54.2 kB	+34 B
Lib overhead (gzip)	14.5 kB	14.6 kB	+17 B

github-actions · 2024-06-11T13:26:46Z

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

github-actions · 2024-06-11T13:29:48Z

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-qg8slgg5b-flows-projects-65bb050e.vercel.app

Built with commit e87fc41.
This pull request is being automatically deployed with vercel-action

pladaria · 2024-06-12T10:45:47Z

jest.base.config.js

@@ -10,8 +11,8 @@ module.exports = {
        '!**/__*__/**', // ignore tests, acceptance, stories, etc
    ],
    transform: {
-        '\\.css\\.ts$': '@vanilla-extract/jest-transform',
-        '^.+\\.(t|j)sx?$': ['@swc/jest', {...swcConfig, sourceMaps: 'inline'}],
+        '\\.css\\.ts$': ['@vanilla-extract/jest-transform', swcTransform],


For some reason, the swc transform is now required in the css.ts files.
It makes sense but I'm not sure why this was working before.

pladaria · 2024-06-12T10:47:57Z

jest.unit.config.js

-    setupFilesAfterEnv: [require.resolve('./setup-test-env.tsx'), '@testing-library/jest-dom/extend-expect'],
+    setupFilesAfterEnv: ['<rootDir>/setup-test-env.tsx'],


the setup-test-env now imports the jest-dom module
https://github.com/testing-library/jest-dom?tab=readme-ov-file#usage

pladaria · 2024-06-12T10:49:05Z

src/__tests__/dialog-test.tsx

-    await userEvent.click(screen.getByTestId('dialog-overlay'));
+    userEvent.click(screen.getByTestId('dialog-overlay'));

    await waitForElementToBeRemoved(() => screen.queryByRole('dialog', {hidden: true}));


If I wait for the click, the test fails because waitForElementToBeRemoved says that the element was already removed.

You can see this fix in several other tests

pladaria · 2024-06-12T10:50:11Z

src/__tests__/radio-button-test.tsx

-    expect(screen.getByText('banana').parentElement).toBeChecked();
-    expect(screen.getByText('apple').parentElement).not.toBeChecked();
+    expect(screen.getByRole('radio', {name: 'banana'})).toBeChecked();
+    expect(screen.getByRole('radio', {name: 'apple'})).not.toBeChecked();


the updated eslint rules forbids direct access to RTL elements

src/__tests__/sheet-test.tsx

pladaria · 2024-06-12T10:52:49Z

src/__tests__/sheet-test.tsx

-    await userEvent.click(closeButton);
-    await waitForElementToBeRemoved(sheet);
-}, 30000);
+    await act(() => userEvent.click(closeButton));


🤷‍♂️

why? afaik RTL already wraps these click events with act internally

I'm not sure. Even if the click triggers an async state update, it should be wrapped by the waitForElementToBeRemoved. But without this I was getting missing act errors.

pladaria · 2024-06-12T10:58:32Z

src/__type_tests__/chip-type-test.tsx

+// @ts-expect-error Chip only accepts string children
 <Chip>
-    {/* @ts-expect-error Chip only accepts string children */}
    <div>hello</div>
 </Chip>;


this is curious, if I remove the @ts-expect-error the reported issue is:

This JSX tag's children prop expects type string which requires multiple children,
but only a single child was provided.

It works as expected (it only accepts a single string child), but I find the error description misleading

pladaria · 2024-06-12T11:00:58Z

tsconfig.json

-        "target": "es2019", // Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. ,
+        "target": "es2021", // Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. ,


required to use String.prototype.replaceAll (it is being used in some test)

pladaria · 2024-06-12T11:06:31Z

src/__stories__/centered-carousel-story.tsx

-                                    {bulletsProps.numPages > 1 && <PageBullets {...bulletsProps} />}
+                                    {(bulletsProps.numPages as number) > 1 && (
+                                        <PageBullets {...bulletsProps} />
+                                    )}


TS v5 now detects (correctly) this as an error, because the type of bulletProps.numPages is:
number | ByBreakpoint<number>

src/__tests__/sheet-test.tsx

atabel · 2024-06-14T08:34:14Z

src/__tests__/sheet-test.tsx

-    await userEvent.click(closeButton);
-    await waitForElementToBeRemoved(sheet);
-}, 30000);
+    await act(() => userEvent.click(closeButton));


why? afaik RTL already wraps these click events with act internally

atabel · 2024-06-14T08:38:36Z

yarn.lock

please, run a yarn dedupe

marcoskolodny · 2024-06-18T17:31:52Z

src/__tests__/dialog-test.tsx

@@ -158,9 +158,9 @@ test('Closes a dialog on click outside', async () => {
    expect(await screen.findByRole('dialog')).toBeInTheDocument();
    expect(await screen.findByRole('button', {name: 'Nope!'})).toBeInTheDocument();

-    await userEvent.click(screen.getByTestId('dialog-overlay'));
+    userEvent.click(screen.getByTestId('dialog-overlay'));


why this? afaik, userEvent.click() returns a promise: https://testing-library.com/docs/user-event/convenience#click

If I wait for the click action to finish, the dialog element is removed too early and the following waitForElementToBeRemoved fails because the element must exist to wait for removal.

…pgrade-deps

yceballost

thx 🫶

…pgrade-deps

tuentisre · 2024-07-05T11:20:32Z

🎉 This PR is included in version 15.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

WEB-1910 upgrade deps

710b06a

WEB-1910 fix tests

59a74c7

pladaria requested review from atabel and marcoskolodny June 11, 2024 15:29

pladaria marked this pull request as ready for review June 11, 2024 15:29

WEB-1910 set data-component-name in ScreenReaderOnly

1dfb009

pladaria removed request for atabel and marcoskolodny June 11, 2024 16:19

pladaria marked this pull request as draft June 11, 2024 16:19

Pedro Ladaria added 2 commits June 12, 2024 11:09

WEB-1910 upgrade ts, ve, vite react plugin

0e6e34f

WEB-1910 fix sheet unit tests

436d7a3

pladaria commented Jun 12, 2024

View reviewed changes

src/__tests__/sheet-test.tsx Show resolved Hide resolved

pladaria commented Jun 12, 2024

View reviewed changes

WEB-1910 fix type

cfbd7b7

pladaria commented Jun 12, 2024

View reviewed changes

Pedro Ladaria added 2 commits June 12, 2024 13:11

WEB-1910 add act

501a9c6

WEB-1910 add timeouts

acf4853

pladaria requested review from atabel and marcoskolodny June 12, 2024 11:40

pladaria marked this pull request as ready for review June 12, 2024 11:40

atabel reviewed Jun 14, 2024

View reviewed changes

WEB-1910 yarn dedupe

abe3399

pladaria requested a review from atabel June 17, 2024 10:36

Merge branch 'master' into pladaria/WEB-1910_upgrade-deps

b9f6271

atabel approved these changes Jun 18, 2024

View reviewed changes

marcoskolodny reviewed Jun 18, 2024

View reviewed changes

Pedro Ladaria added 2 commits June 20, 2024 11:58

Merge remote-tracking branch 'origin/master' into pladaria/WEB-1910_u…

cdc8f68

…pgrade-deps

WEB-1910 update playroom

2f61223

pladaria requested review from yceballost and marcoskolodny June 20, 2024 10:27

WEB-1910 fix prettier

18fdbf7

yceballost approved these changes Jun 20, 2024

View reviewed changes

marcoskolodny approved these changes Jun 25, 2024

View reviewed changes

Pedro Ladaria added 2 commits June 27, 2024 10:19

Merge remote-tracking branch 'origin/master' into pladaria/WEB-1910_u…

4bcfa55

…pgrade-deps

WEB-1910 await clicks in unit tests

5751022

pladaria enabled auto-merge June 27, 2024 08:34

WEB-1910 fix test

8afdd82

pladaria added this pull request to the merge queue Jun 27, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024

pladaria and others added 2 commits July 2, 2024 18:36

Merge branch 'master' into pladaria/WEB-1910_upgrade-deps

ac1be67

WEB-1910 increase test times

e87fc41

pladaria enabled auto-merge July 2, 2024 16:38

pladaria added this pull request to the merge queue Jul 2, 2024

Merged via the queue into master with commit 112679f Jul 2, 2024
11 checks passed

pladaria deleted the pladaria/WEB-1910_upgrade-deps branch July 2, 2024 16:58

tuentisre added the released label Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(dependencies): upgrade dependencies #1147

chore(dependencies): upgrade dependencies #1147

pladaria commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

pladaria Jun 12, 2024

pladaria Jun 12, 2024

pladaria Jun 12, 2024 •

edited

Loading

pladaria Jun 12, 2024

pladaria Jun 12, 2024

atabel Jun 14, 2024

pladaria Jun 17, 2024 •

edited

Loading

pladaria Jun 12, 2024 •

edited

Loading

pladaria Jun 12, 2024

pladaria Jun 12, 2024 •

edited

Loading

atabel Jun 14, 2024

atabel Jun 14, 2024

pladaria Jun 17, 2024

marcoskolodny Jun 18, 2024

pladaria Jun 20, 2024 •

edited

Loading

yceballost left a comment

tuentisre commented Jul 5, 2024

		setupFilesAfterEnv: [require.resolve('./setup-test-env.tsx'), '@testing-library/jest-dom/extend-expect'],
		setupFilesAfterEnv: ['<rootDir>/setup-test-env.tsx'],

		"target": "es2019", // Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. ,
		"target": "es2021", // Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. ,

chore(dependencies): upgrade dependencies #1147

chore(dependencies): upgrade dependencies #1147

Conversation

pladaria commented Jun 11, 2024 • edited Loading

github-actions bot commented Jun 11, 2024 • edited Loading

github-actions bot commented Jun 11, 2024 • edited Loading

github-actions bot commented Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pladaria Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pladaria Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

pladaria Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pladaria Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pladaria Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

yceballost left a comment

Choose a reason for hiding this comment

tuentisre commented Jul 5, 2024

pladaria commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

pladaria Jun 12, 2024 •

edited

Loading

pladaria Jun 17, 2024 •

edited

Loading

pladaria Jun 12, 2024 •

edited

Loading

pladaria Jun 12, 2024 •

edited

Loading

pladaria Jun 20, 2024 •

edited

Loading