Sys margins #199
Sys margins #199
Conversation
remove unnecessary SI parameters in eqpt config.json: -rx osnr -bit rate -min spacing -cost remove nb_channel parameter when calling SI Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
add Tx_osnr or add_drop_osnr on raw snr values to avoid cumulated adding Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com> bug fix: forgot to add add_drop_osnr with tx_osnr Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
add_drop_osnr contribution is added at the end of the transmission propagation, at the same time as Tx_osnr Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
remove path propagation for each mode path propogation is only done for each baud rate Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
-read sys_margins in equipment['SI'] -add sys_margins to all Transceivers OSNR for path feasibility check (path_request_run only) Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
|
I had a quick look and just have a couple of minor comments: -It's a bit confusing to see assignments like -I'm not sure it makes sense to add tx_osnr and add_drop_osnr to osnr_nli. I think osnr_nli should only include nonlinear interference noise computed by the GN-model.. -The README should probably be updated to explain the new parameters add_drop_osnr and sys_margins |
|
Hi jonas, you are absolutely right, it makes no sense to add it to the osnr_nli: I must have been in automatic mode ;) I will correct this. |
Signed-off-by: Jean-Luc Auge <jeanluc.auge@orange.com>
Tx_OSNR added at the end of propagation
Terminal ROADM add drop OSNR contribution (in eqpt_config / ROADM)
System margins contribution (in eqpt_config / SI)
code cleaning for the SI function