Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crystal] Updates to the README and small change to improve the connection pool… #9515

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions frameworks/Crystal/amber/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,12 @@ This is the [Amber](https://amberframework.org) test of the Framework Benchmarks

The purpose of Amber is not to create yet another framework, but to take advantage of the beautiful Crystal language capabilities and provide engineers an efficient, cohesive, and well maintain web framework for the crystal community that embraces the language philosophies, conventions, and guides.

Amber Crystal borrows concepts that already have been battle tested, successful, and embrace new concepts through team and community collaboration and analysis, that aligns with Crystal philosophies.
Amber borrows concepts that already have been battle tested, successful, and embrace new concepts through team and community collaboration and analysis, that aligns with Crystal philosophies.

## Contributors
Updated for Amber 1.4.1 and Crystal 1.14.0

- Dru Jensen [drujensen](https://github.com/drujensen)
- Elias Perez [eliasjpr](https://github.com/eliasjpr)
- Isaac Sloan [elorest](https://github.com/elorest)
- Faustino Aguilar [faustinoaq](https://github.com/faustinoaq)
- Nick Franken [fridgerator](https://github.com/fridgerator)
- Mark Siemers [marksiemers](https://github.com/marksiemers)
- Robert Carpenter [robacarp](https://github.com/robacarp)
## Contributors
- Seth Tucker [crimson-knight](https://github.com/crimson-knight)

See more [Amber contributors](https://github.com/amberframework/amber/graphs/contributors)

Expand Down
4 changes: 2 additions & 2 deletions frameworks/Crystal/amber/config/initializers/database.cr
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "granite/adapter/pg"

cpu_count = System.cpu_count
pool_size = 56 // cpu_count
cpu_count = System.cpu_count - 1 # Always leave 1 core for the system
pool_size = cpu_count * 4 # 4x the number of cores, should be plenty of room for concurrency
database_url = ENV["DATABASE_URL"]
url = "#{database_url}?initial_pool_size=#{pool_size}&max_idle_pool_size=#{pool_size}"

Expand Down
28 changes: 2 additions & 26 deletions frameworks/Crystal/amber/shard.lock
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ shards:
git: https://github.com/crystal-lang/crystal-db.git
version: 0.11.0

dotenv:
git: https://github.com/gdotdesign/cr-dotenv.git
version: 1.0.0

exception_page:
git: https://github.com/crystal-loot/exception_page.git
version: 0.3.1
Expand All @@ -44,22 +40,10 @@ shards:
git: https://github.com/amberframework/granite.git
version: 0.23.3

i18n:
git: https://github.com/crimson-knight/i18n.cr.git
version: 0.4.1

ifrit:
git: https://github.com/imdrasil/ifrit.git
version: 0.1.3

inflector:
git: https://github.com/phoffer/inflector.cr.git
version: 1.0.0

jennifer:
git: https://github.com/imdrasil/jennifer.cr.git
version: 0.13.0

json_mapping:
git: https://github.com/crystal-lang/json_mapping.cr.git
version: 0.1.1
Expand All @@ -74,15 +58,15 @@ shards:

micrate:
git: https://github.com/amberframework/micrate.git
version: 0.15.0
version: 0.15.1

mysql:
git: https://github.com/crystal-lang/crystal-mysql.git
version: 0.14.0

optarg:
git: https://github.com/amberframework/optarg.git
version: 0.9.3
version: 0.9.5

pg:
git: https://github.com/will/crystal-pg.git
Expand All @@ -96,10 +80,6 @@ shards:
git: https://github.com/stefanwille/crystal-redis.git
version: 2.8.3

sam:
git: https://github.com/imdrasil/sam.cr.git
version: 0.5.0

shell-table:
git: https://github.com/luckyframework/shell-table.cr.git
version: 0.9.3
Expand All @@ -116,10 +96,6 @@ shards:
git: https://github.com/amberframework/teeplate.git
version: 0.11.2

wordsmith:
git: https://github.com/luckyframework/wordsmith.git
version: 0.4.0

yaml_mapping:
git: https://github.com/crystal-lang/yaml_mapping.cr.git
version: 0.1.1
Expand Down
16 changes: 0 additions & 16 deletions frameworks/Crystal/amber/shard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,10 @@ dependencies:
github: amberframework/amber
version: 1.4.1

jennifer:
github: imdrasil/jennifer.cr
version: "~> 0.13.0"

sam:
github: imdrasil/sam.cr
version: 0.5.0

pg:
github: will/crystal-pg
version: "= 0.26.0"

mysql:
github: crystal-lang/crystal-mysql
version: 0.14.0

dotenv:
github: gdotdesign/cr-dotenv
version: 1.0.0

granite:
github: amberframework/granite
version: 0.23.3
Loading