Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Nans in input of Permutation Importance #381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update sklearn requirement to 0.20
  • Loading branch information
uj26kf committed Nov 11, 2020

Verified

This commit was signed with the committer’s verified signature.
sanjayankur31 Ankur Sinha
commit fc22f65585a721ebd475bf868b3fd7083cf67ae8
2 changes: 1 addition & 1 deletion eli5/sklearn/permutation_importance.py
Original file line number Diff line number Diff line change
@@ -196,7 +196,7 @@ def fit(self, X, y, groups=None, **fit_params):
self.estimator_ = clone(self.estimator)
self.estimator_.fit(X, y, **fit_params)

X = check_array(X, force_all_finite=False)
X = check_array(X, force_all_finite='allow-nan')

if self.cv not in (None, "prefit"):
si = self._cv_scores_importances(X, y, groups=groups, **fit_params)
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
numpy >= 1.9.0
scipy
singledispatch >= 3.4.0.3
scikit-learn >= 0.18
scikit-learn >= 0.20
attrs > 16.0.0
jinja2
pip >= 8.1
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ def get_long_description():
'numpy >= 1.9.0',
'scipy',
'six',
'scikit-learn >= 0.18',
'scikit-learn >= 0.20',
'graphviz',
'tabulate>=0.7.7',
],
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
; https://github.com/Microsoft/LightGBM/tree/master/python-package#lightgbm-python-package.

[tox]
envlist = py27,py34,py35,py35-nodeps,mypy,py35-extra,py27-extra,py36,py36-extra,py36-legacy,py37-nodeps
envlist = py27,py34,py35,py35-nodeps,mypy,py35-extra,py27-extra,py36,py36-extra,py37-nodeps

[base]
deps=