Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] 팀 정보 수정 로직 분리 및 팀 정보 반환시 팀 이름 변경 날짜 반환 #217

Merged
merged 4 commits into from
Dec 31, 2024
Merged

[CHORE] 팀 정보 수정 로직 분리 및 팀 정보 반환시 팀 이름 변경 날짜 반환 #217

merged 4 commits into from
Dec 31, 2024

Conversation

paragon0107
Copy link
Contributor

✨ Related Issue

📝 기능 구현 명세

  • 이곳에는 postman 테스트 결과를 넣어주세요

🐥 추가적인 언급 사항

기존에 일반 유저용 API 어드민 유저용 API로 나눴는데
도메인 별로 나누는걸로 수정했습니다.

@paragon0107 paragon0107 requested a review from Chan531 December 31, 2024 07:25
@paragon0107 paragon0107 self-assigned this Dec 31, 2024
@paragon0107 paragon0107 linked an issue Dec 31, 2024 that may be closed by this pull request
[CHORE] 워크스페이스 설정 로직 수정 #216
Closed
2 tasks
Chan531
Chan531 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~! 추후에 dto 초기화 방식을 빌더 패턴으로 할 지 생성자로 할 지 정해보면 좋을 거 같아요~!

@paragon0107 paragon0107 merged commit 03c8339 into develop Dec 31, 2024
1 check passed
@paragon0107 paragon0107 deleted the chore-/#216-workspace-setting branch December 31, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

Assignees

@paragon0107 paragon0107

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] 워크스페이스 설정 로직 수정
2 participants
@paragon0107 @Chan531