Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add models object property #44

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: add models object property #44

merged 2 commits into from
May 23, 2024

Conversation

Dttbd
Copy link
Collaborator

@Dttbd Dttbd commented May 14, 2024 •
edited by jameszyao
Loading

Pull Request

PR Description

Add object filed to pydantic models

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • [ X ] I have read the CONTRIBUTING.md guidelines.
  • [ X ] I have tested my changes locally to ensure they are effective.
  • [ X ] I have updated the necessary documentation (if applicable).

@Dttbd Dttbd requested a review from jameszyao May 14, 2024 03:07
jameszyao
jameszyao approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jameszyao jameszyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameszyao jameszyao merged commit 2f3686b into master May 23, 2024
1 check passed
@jameszyao jameszyao deleted the feat/add_object_property branch June 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameszyao jameszyao jameszyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dttbd @jameszyao @taskingaijc