Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add max_tokens to query_chunks api schema #25

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: add max_tokens to query_chunks api schema #25

merged 1 commit into from
Mar 11, 2024

Conversation

jameszyao
Copy link
Contributor

Pull Request

PR Description

fix: add max_tokens to query_chunks api schema

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING.md guidelines.
  • I have tested my changes locally to ensure they are effective.
  • I have updated the necessary documentation (if applicable).

Additional Information

Provide any other important information about this PR here.

@jameszyao jameszyao requested a review from SimsonW March 11, 2024 04:32
SimsonW
SimsonW approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@SimsonW SimsonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimsonW SimsonW merged commit 1d88a83 into master Mar 11, 2024
1 check passed
@jameszyao jameszyao deleted the fix/update-query-chunk-api-schema branch April 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimsonW SimsonW SimsonW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameszyao @SimsonW