Feature/new feature #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as i removed observers ondestroy so even though the audio will play in the background no other part of the activity will me running thus reducing power consumption
…ll as i removed observers ondestroy so even though the audio will play in the background no other part of the activity will me running thus reducing power consumption
…ll as i removed observers ondestroy so even though the audio will play in the background no other part of the activity will me running thus reducing power consumption along with that i added a notification for user to stop the music from the notification bar itself. i also addeda few toast messages to tell the user what the issue is.
TangoBeee
reviewed
Oct 3, 2024
Comment on lines
66
to
71
| noInternetLiveData.observe(this) { noInternet -> | ||
| if (noInternet) { | ||
| Snackbar.make(binding.root, getString(R.string.no_internet), Snackbar.LENGTH_INDEFINITE) | ||
| .setAction(getString(R.string.retry)) { | ||
| fetchData() // Retry fetching data | ||
| }.show() |
There was a problem hiding this comment.
Can you remove that Snackbar? When I am trying to open my app without internet I am not able to see any Snackbar.
There was a problem hiding this comment.
i have removed that snackbar tangobeee now the notification should work to stop music plsu the toast messages without any unnecessary snackbar code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey tango bee i have followed up on my last pull request and i have added toast messages instead of snack bars and i have also added a notification to stop music directly outside the app aswell as i removed observers to reduce the battery consumption. I have tested everything this time and added images. Please test these features on a device Android 13 or greater for optimum results.
