Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cancellation): add graphql request v4 example #3264

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

arnaudbzn
Copy link
Contributor

graphql-request v4.0 now supports setting an AbortSignal per request.
A new Query cancellation example has been added.

Related PR graffle-js/graffle#303

@vercel
Copy link

vercel bot commented Feb 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/J1KJ2MHTTSqgSaX3bmUDpnyB7KzH
✅ Preview: https://react-query-git-fork-arnaudbzn-docs-cancellatio-8fd505-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d59aec:

Sandbox Source
tannerlinsley/react-query Configuration

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #3264 (9d59aec) into master (a536773) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3264   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files          45       45           
  Lines        1648     1648           
  Branches      339      339           
=======================================
  Hits         1283     1283           
  Misses         47       47           
  Partials      318      318           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a536773...9d59aec. Read the comment docs.

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 5, 2022

@arnaudbzn do you know what's up with the code coverage? It dropped 18% today for no apparent reason 🤔

@arnaudbzn
Copy link
Contributor Author

arnaudbzn commented Feb 5, 2022

@arnaudbzn do you know what's up with the code coverage? It dropped 18% today for no apparent reason 🤔

.md should not impact the coverage.

I get 96% on my branch:
Screenshot 2022-02-05 at 12 38 47

@arnaudbzn
Copy link
Contributor Author

It seems to have started to decrease to 78% a few commits ago, but it is not consistent with local yarn test:coverage results.

Screenshot 2022-02-05 at 12 56 40

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 5, 2022

Yes it started here: https://twitter.com/tkdodo/status/1489867753267867649

i have no idea why though :(

@TkDodo TkDodo merged commit efb77d7 into TanStack:master Feb 5, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants