Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user in bank transaction to be blank in forms #539

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

Janne555
Copy link
Collaborator

@Janne555 Janne555 commented Feb 1, 2025

User relation can be null but form validation doesn't allow for blank values. Allow blank values to make it possible to comment transactions without users.

closes #513

Copy link
Collaborator

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@braaar braaar changed the title Allow user to be blank in bank transaction fix: allow user in bank transaction to be blank in forms Feb 1, 2025
@braaar braaar merged commit d28f57d into master Feb 1, 2025
1 check passed
@braaar braaar deleted the fix/allow-blank-for-user-in-bank-statements branch February 1, 2025 16:56
braaar added a commit to HacklabJKL/mulysa that referenced this pull request Feb 1, 2025
* main:
  fix: allow user in bank transaction to be blank in forms (TampereHacklab#539)
  Korjattu assertti
  Feature/matrix invites (TampereHacklab#488)
  fix ci (TampereHacklab#533)
  Update account_deactivated_and_marked_for_deletion.txt (TampereHacklab#500)
  Bump Python version to 3.11 used in Debian 12 (TampereHacklab#523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a comment to a bank transaction requires selecting a User from the drop down menu
2 participants