Features: Enable and Ship Developer Specialties, Badge Filters #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.9.0 to 5.7.0. - [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases) - [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md) - [Commits](honeybadger-io/honeybadger-ruby@v4.9.0...v5.7.0) --- updated-dependencies: - dependency-name: honeybadger dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pagy](https://github.com/ddnexus/pagy) from 5.2.0 to 7.0.11. - [Release notes](https://github.com/ddnexus/pagy/releases) - [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md) - [Commits](ddnexus/pagy@5.2.0...7.0.11) --- updated-dependencies: - dependency-name: pagy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [apnotic](https://github.com/ostinelli/apnotic) from 1.7.0 to 1.7.1. - [Commits](ostinelli/apnotic@1.7.0...1.7.1) --- updated-dependencies: - dependency-name: apnotic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the erb_lint group with 1 update: [erb_lint](https://github.com/Shopify/erb-lint). Updates `erb_lint` from 0.1.2 to 0.1.3 - [Release notes](https://github.com/Shopify/erb-lint/releases) - [Commits](Shopify/erb_lint@v0.1.2...v0.1.3) --- updated-dependencies: - dependency-name: erb_lint dependency-type: direct:development update-type: version-update:semver-patch dependency-group: erb_lint ... Signed-off-by: dependabot[bot] <support@github.com>
* Modeling, migrations, and seeds * Admin CRUD * UI for displaying developer specialties * Disable rate limiting in development Sometimes requesting a bunch of assets via Active Storage can hit the rate limit. * Feature flag to hide specialties for now * Remove ivar from partial * Namespace controller and clean up disabled button * Disable linters that get in way of multiline calls * Use Rails.root.join directly * Increase spacing in developer form fields * Specialty checkbox selection * Limit specialties to 5 * Small form design tweaks * Fix CI - unused + missing translations * Don't downcase specialties; start seed backfill * Move badges logic/queries to concern * Match design of other filter labels * Don't send "commit" URL param when submitting form * Filtering by specialty * Filtering by "High response rate" badge * Update specialties seed * Normalize locales * mailto: link to suggest new developer specialty * Add new developer specialties * WIP * Specialty filters JS/no JS initial version * Initial version of specialty adding/removing * Make sure the pill data is submitted when the form is submitted * Initial version ready * Writing tests * Refactoring: renaming attach_template_tags_controller to javascript_enabled_controller * Don't duplicate a pill * Minor refactoring * Refactoring: extract method * Refactor: dropdown_pill_controller * Minor refactor * Resuse specialty_dropdown_component * Refactor dropdown_pill controller to be scoped to element * Remove unused files * Remove unused files, minor refactor * Cleanup * Linting * Update changelog with #820 * Adjust for extra developer fixture --------- Co-authored-by: Joe Masilotti <joe@masilotti.com> Co-authored-by: Mia Sinek <mia@miasinek.com>
chtzvt
added a commit
that referenced
this pull request
Mar 27, 2024
* build(deps): bump honeybadger from 4.9.0 to 5.7.0 Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.9.0 to 5.7.0. - [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases) - [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md) - [Commits](honeybadger-io/honeybadger-ruby@v4.9.0...v5.7.0) --- updated-dependencies: - dependency-name: honeybadger dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump pagy from 5.2.0 to 7.0.11 Bumps [pagy](https://github.com/ddnexus/pagy) from 5.2.0 to 7.0.11. - [Release notes](https://github.com/ddnexus/pagy/releases) - [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md) - [Commits](ddnexus/pagy@5.2.0...7.0.11) --- updated-dependencies: - dependency-name: pagy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump apnotic from 1.7.0 to 1.7.1 Bumps [apnotic](https://github.com/ostinelli/apnotic) from 1.7.0 to 1.7.1. - [Commits](ostinelli/apnotic@1.7.0...1.7.1) --- updated-dependencies: - dependency-name: apnotic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump the erb_lint group with 1 update Bumps the erb_lint group with 1 update: [erb_lint](https://github.com/Shopify/erb-lint). Updates `erb_lint` from 0.1.2 to 0.1.3 - [Release notes](https://github.com/Shopify/erb-lint/releases) - [Commits](Shopify/erb_lint@v0.1.2...v0.1.3) --- updated-dependencies: - dependency-name: erb_lint dependency-type: direct:development update-type: version-update:semver-patch dependency-group: erb_lint ... Signed-off-by: dependabot[bot] <support@github.com> * Feature: Developer Specialties Combobox (#70) * Modeling, migrations, and seeds * Admin CRUD * UI for displaying developer specialties * Disable rate limiting in development Sometimes requesting a bunch of assets via Active Storage can hit the rate limit. * Feature flag to hide specialties for now * Remove ivar from partial * Namespace controller and clean up disabled button * Disable linters that get in way of multiline calls * Use Rails.root.join directly * Increase spacing in developer form fields * Specialty checkbox selection * Limit specialties to 5 * Small form design tweaks * Fix CI - unused + missing translations * Don't downcase specialties; start seed backfill * Move badges logic/queries to concern * Match design of other filter labels * Don't send "commit" URL param when submitting form * Filtering by specialty * Filtering by "High response rate" badge * Update specialties seed * Normalize locales * mailto: link to suggest new developer specialty * Add new developer specialties * WIP * Specialty filters JS/no JS initial version * Initial version of specialty adding/removing * Make sure the pill data is submitted when the form is submitted * Initial version ready * Writing tests * Refactoring: renaming attach_template_tags_controller to javascript_enabled_controller * Don't duplicate a pill * Minor refactoring * Refactoring: extract method * Refactor: dropdown_pill_controller * Minor refactor * Resuse specialty_dropdown_component * Refactor dropdown_pill controller to be scoped to element * Remove unused files * Remove unused files, minor refactor * Cleanup * Linting * Update changelog with #820 * Adjust for extra developer fixture --------- Co-authored-by: Joe Masilotti <joe@masilotti.com> Co-authored-by: Mia Sinek <mia@miasinek.com> * codeboxx badge: add scope and make searchable * Feat: enable specialties and badge filters --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joe Masilotti <joe@masilotti.com> Co-authored-by: Mia Sinek <mia@miasinek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #70, bringing in the latest version of the specialties UI/UX from upstream (joemasilotti/railsdevs.com#868). It also enables the dormant badge filter, which I believe is quite useful, and enables these features to run in production.
Pull request checklist
bin/check