Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unified address format #1782

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

feat: unified address format #1782

wants to merge 10 commits into from

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Jan 14, 2025 •
edited
Loading

TODO before merging:

  • update the url of the documentation page in constants.ts (waiting on url of the polkadot wiki page)
  • remove the temporary code that overrides prefixes in ChaindataProvider.ts (can't test without it as no chain migrated yet)
  • turn off UNIFIED_ADDRESS_BANNER feature flag in remote config

@0xKheops 0xKheops marked this pull request as ready for review January 14, 2025 08:07
@0xKheops 0xKheops marked this pull request as draft January 14, 2025 08:07
@0xKheops 0xKheops changed the title feat: add oldPrefix property on Chain type feat: unified address format Jan 15, 2025
@0xKheops 0xKheops requested a review from chidg January 16, 2025 09:11
@chidg
Copy link
Contributor

chidg commented Jan 24, 2025

LGTM pending updated 'Learn More' link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg Awaiting requested review from chidg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xKheops @chidg