fix: errors in balance pool (#1788)

* fix: unawaited promise in chaindata provider * fix: null check in balance pool * fix: unawaited promise * chore: add async await back to wrapObservableWithGetter --------- Co-authored-by: alecdwm <2741569+alecdwm@users.noreply.github.com>
TalismanSociety · Jan 22, 2025 · d20764a · d20764a
1 parent d4ebb87
commit d20764a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/fuzzy-penguins-promise.md b/.changeset/fuzzy-penguins-promise.md
@@ -0,0 +1,5 @@
+---
+"@talismn/chaindata-provider": patch
+---
+
+fix: unawaited promise
diff --git a/packages/chaindata-provider/src/util.ts b/packages/chaindata-provider/src/util.ts
@@ -113,9 +113,12 @@ export const wrapObservableWithGetter = async <O extends Observable<any>>(
   return await withErrorReason(errorReason, () => firstValueFrom(observable))
 }
 
-export const withErrorReason = <T>(reason: string, task: () => T): T => {
+export const withErrorReason = async <T>(
+  reason: string,
+  task: () => Promise<T> | T,
+): Promise<T> => {
   try {
-    return task()
+    return await task()
   } catch (cause) {
     throw new Error(reason, { cause })
   }

diff --git a/packages/extension-core/src/domains/balances/pool.ts b/packages/extension-core/src/domains/balances/pool.ts
@@ -76,7 +76,7 @@ const getActiveStuff = <T extends { isTestnet?: boolean }, A extends Record<stri
   return combineLatest([dataObservable, activeStoreObservable, settingsStore.observable]).pipe(
     map(([data, active, { useTestnets }]) => {
       return data
-        .filter((item) => isActiveFn(item, active))
+        .filter((item) => !!item && isActiveFn(item, active))
         .filter((item) => (useTestnets ? true : !item.isTestnet))
     }),
   )