Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Endless loop account renaming #2049

Closed
jdsika opened this issue Oct 26, 2023 · 4 comments
Closed

Bug: Endless loop account renaming #2049

jdsika opened this issue Oct 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jdsika
Copy link

jdsika commented Oct 26, 2023

System:
IOS
iPhone 12,8
System Version: 16.7.1
Wallet Build: 1.23.0 (302)

How to reproduce:
I installed the app. Initialize the wallet creating new set of addresses with seed words.
Click on edit the name of the account.
Enter name and click "save"
New name is displayed and the system is in endless loop (see screenshot)

If I force shutdown the application and restart it I can see the chnaged name.

Expectation:
No endless Loop

bug

@jdsika
Copy link
Author

jdsika commented Oct 26, 2023

I already mentioned that in #1716 but I am creating this extra ticket as it is still not fixed

@hawkbee1 hawkbee1 added the bug Something isn't working label Oct 31, 2023
@dansan566
Copy link

Experienced the same!

@dansan566
Copy link

Also, if you close the App and go back in, the account has been renamed accordingly. However, there are two account ownership cards with the same address:

image

@jdsika
Copy link
Author

jdsika commented Nov 3, 2023

This was a good catch from Daniel! So this duplicated card I have described in my issue is happening because of the account renaming

          Thanks for your feedback @jdsika, I will probably create several tickets. I understand you have twos ownership cards in "My blockchain accounts" section, both identical. Could you tell me which network is written on the cards ?

Originally posted by @hawkbee1 in #1716 (comment)

@bibash28 bibash28 self-assigned this Nov 9, 2023
hawkbee1 pushed a commit that referenced this issue Nov 13, 2023
* feat: Remove endless loop while account renaming #2049

* refactor: Fix bug of not storing network changes #2064

* feat: Remove reward feature #2045

* version update

* feat: Rename wallet credential into wallet attestation #2079

* feat: Remove claim check in oidc4vc test

* feat: Update scope support string & Verify request if subject syntax type also enabled

* version update

* feat: Change image for wallet credential

* version update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants