Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

[WIP] Disable HTML support #128

Merged
merged 4 commits into from
Apr 22, 2016
Merged

[WIP] Disable HTML support #128

merged 4 commits into from
Apr 22, 2016

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Apr 21, 2016

  • Disable HTML support
  • Simplify parsing (no need to deal with HTML malformed blocks anymore)
  • Add noreferrer and noopener rels to links

cf. #122

There are a few known issues/changes:

  • No way to add custom CSS classes => not really usable anyway
  • No more support for kbd (I'd like to find a way to get it back) 😞 (cf. Add support for <kbd> #129)
  • (Hidden) FontAwesome support becomes :fa-<icon>: (much better)

* Simplify parsing (no need to deal with HTML malformed blocks anymore)
* Add noreferrer and noopener rels to links

cf. #122
@willdurand willdurand force-pushed the remove-html-support branch from 757ae52 to 8197123 Compare April 21, 2016 10:16
@willdurand willdurand temporarily deployed to staging April 22, 2016 07:33 Inactive
@willdurand willdurand mentioned this pull request Apr 22, 2016
@willdurand willdurand temporarily deployed to staging April 22, 2016 08:52 Inactive
@willdurand willdurand changed the title [WIP] [RFC] Disable HTML support [WIP] Disable HTML support Apr 22, 2016
@willdurand
Copy link
Member Author

willdurand commented Apr 22, 2016

Ah snap! The sub plugin conflicts with strikethrough :(

@willdurand willdurand force-pushed the remove-html-support branch from ae615c3 to bf820b8 Compare April 22, 2016 09:15
@jmaupetit
Copy link
Member

No way to add custom CSS classes

We will support this when attributes syntax will be added to commonmark specs

No more support for kbd (I'd like to find a way to get it back)

I am pretty sure we will find a way to add this (like fontawesome integration)

(Hidden) FontAwesome support becomes :fa-: (much better)

👍

To sum up: LGTM

@jmaupetit jmaupetit merged commit 10e4a5e into master Apr 22, 2016
@jmaupetit jmaupetit deleted the remove-html-support branch April 22, 2016 09:24
@jmaupetit jmaupetit removed the doing label Apr 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants