Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved checkduplicates test and restructure project #14

Merged
merged 25 commits into from
Nov 18, 2024

Conversation

TabulateJarl8
Copy link
Owner

@TabulateJarl8 TabulateJarl8 commented Nov 17, 2024

This is a pretty big pull request. Here's the list of changes:

  • Rewrote the checkduplicates test in Rust using Wagner-Fischer, improving it's speed from ~400k it/s to ~1.4M it/s.
  • Restructured the project to use poetry instead of setup.py
  • Rewrite the tests in PyTest and put pytest-cov into place with 100% code coverage
  • Removed some newly found duplicate facts and fixed some fact typos

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@TabulateJarl8 TabulateJarl8 merged commit 5e6786e into master Nov 18, 2024
6 checks passed
@TabulateJarl8 TabulateJarl8 deleted the improved_tests branch November 18, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants