-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for building on jetson device #620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and running CIs
Oops, seems that there is a lint problem. I'm pretty new to Rust, where should I look at? |
You could run |
Ok, I'm digging into it. |
@wsxiaoys Wierd, My |
You might also fix the fmt based on information here: https://github.com/TabbyML/tabby/actions/runs/6623245595/job/17990064469?pr=620 |
@wsxiaoys I've pushed the result of |
This is screenshot from link https://github.com/TabbyML/tabby/actions/runs/6623245595/job/17990064469?pr=620 |
@wsxiaoys Yes, I've studied that log, cannot find any information why the code failed to lint. The error just shows "Process completed with exit code 1." at somewhere around line 42. And, this time, it does not complain anymore after I format the code at line 47. weird. |
The current building flow will fail on Jetson, because the CTranslate2 binding turns the "sse4.1" flag on while it's not available on Jetson.
I've added a function to check whether it's building on the NVIDIA Jetson device or not. If true, it will turn on CUDA and CUDNN flags of CTranslate2.
I've tested building on Intel CPU, AMD CPU, Jetson Orin Nano, Jetson Orin AGX.