Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vim): rework vim plugin with lsp client. bump version to 2.0.0-dev. #3103

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

icycodes
Copy link
Member

@icycodes icycodes commented Sep 9, 2024

Notable Changes in vim-tabby Plugin 2.0

Since version 2.0, the vim-tabby plugin is designed as two parts:

  1. LSP Client Extension:
    • Relies on an LSP client and extends it with methods (such as textDocument/inlineCompletion) to communicate with the tabby-agent.
  2. Inline Completion UI:
    • Automatically triggers inline completion requests when typing.
    • Renders the inline completion text as ghost text.
    • Sets up actions with keyboard shortcuts to accept or dismiss the inline completion.

Requirements Changes

  • The Node.js script of tabby-agent is no longer a built-in part of the vim-tabby plugin. You need to install tabby-agent separately via npm, and the LSP client will launch it using the command npx tabby-agent --stdio.
  • Requires a LSP client. The Neovim built-in LSP client, or a Vim plugin that provides an LSP client.

Supported LSP clients

  • The Neovim built-in LSP client, with the nvim-lspconfig plugin installed.
  • More clients are in development.

@icycodes icycodes marked this pull request as draft September 9, 2024 02:09
@icycodes icycodes force-pushed the feat-vim-rework-lsp-client branch from 68cc0d2 to 14814c5 Compare October 16, 2024 10:04
@icycodes icycodes marked this pull request as ready for review October 16, 2024 11:33
@icycodes icycodes requested a review from wsxiaoys October 16, 2024 11:33
@wsxiaoys wsxiaoys enabled auto-merge (squash) October 16, 2024 11:35
@icycodes icycodes disabled auto-merge October 17, 2024 01:39
@icycodes icycodes merged commit f362d06 into TabbyML:main Oct 17, 2024
15 checks passed
@icycodes icycodes deleted the feat-vim-rework-lsp-client branch October 17, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants