-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix reference syntax #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the space mandatory now or just a visual thing?
The reST Syntax asks for the space. However Spinx interprets references without the space correctly and does not throw warnings. the phpdocumentor/guides currently do not interpret such references correctly. But as it is a common mistake and worked until now I made a PR to also allow it in the guides: phpDocumentor/guides#851 |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-11.5 11.5
# Navigate to the new working tree
cd .worktrees/backport-11.5
# Create a new branch
git switch --create backport-319-to-11.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 62dabf5005645b9fafbac535471a7d0daa8f39b0
# Push it to GitHub
git push --set-upstream origin backport-319-to-11.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-11.5 Then, create a pull request where the |
(cherry picked from commit 8f7cae3)
No description provided.