Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove 'type' from note about bad parameters #1462

Closed

Conversation

kitzberger
Copy link
Contributor

In previous versions of TYPO3 this might have been true, but I don't see any reason, why type shouldn't be used in config.linkVars.

This goes probably back to: https://forge.typo3.org/issues/25317

I've tested it with TYPO3 12 and couldn't find any side effects.

Here's my scenario:

pageTest = PAGE
pageTest {
    typeNum = 1234

    config.linkVars = type

    10 = TEXT
    10.typolink.parameter = 1
    10.typolink.returnLast = url
    10.noTrimWrap = |Link: |<br>|
}

@froemken
Copy link
Contributor

froemken commented Dec 5, 2024

Hello @kitzberger

if you do not work with RouteEnhancer PageType decorator you're just fine, but as most people outside are working with PageType decorator https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Routing/AdvancedRoutingConfiguration.html#routing-pagetype-decorator the $_GET parameter type will not be interpreted anymore. The type and L parameter will be removed in near future. So, it's good to not relate on them.

Thank you for your patch, but I don't think that we will merge that.

Stefan

@kitzberger
Copy link
Contributor Author

@froemken, thanks for explaining.

How would you ensure then to render links within a non-0 typeNum that use their own type-parameter? For single typolinks this could be achieved by specifying the type appended like typolink.parameter = 1,1234.

But for generated menus or links placed in RTE, it's only possible by using linkVars=type, isn't it?

@froemken
Copy link
Contributor

froemken commented Dec 5, 2024

Hello @kitzberger

Do you see the map part in Page decorator? Only type parameters defined here are valid. So, if you set a link to use type 123 it will automatically looked up there and implemented with the human readable string into the link. If you write the URL manually somewhere and add &type=123 and page decorator is used IMO this type parameter will not be interpreted by TYPO3 anymore. So, there is no need to set the allowed types in linkVars.

@kitzberger
Copy link
Contributor Author

@froemken, oh, you're absolutely right. Thanks for elaborating!

@kitzberger kitzberger closed this Dec 5, 2024
@kitzberger kitzberger deleted the linkVars-type-tweak branch December 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants