-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Document Extbase FileUpload #4808
Conversation
The first section about the history is "new content". Starting with "_extbase_fileupload_attribute" the rest is taken from the well-written Changelog entry. Closes TYPO3-Documentation/Changelog-To-Doc#1040 Releases: main, 12.4
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write "Domain Model" lowercase, like written here:
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/Domain/Model.html#introduction
Additionally, you wrote sometimes "Domain Model" and sometimes "domain model".
I just checked the first part. The last part I'll do later.
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
…ad.rst Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
…ad.rst Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
remove "easy/easily" Domain Model -> domain model
Do you really want to backport it to 12.4? Mostly it is about 13? |
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adressed the changes by @derhansen and @brotkrueml
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Outdated
Show resolved
Hide resolved
A manual backport, yes. I want to keep the first section and then only hint at the v13 change. I didn't have time enough to split this up into a pre-patch because I need this for v13, and the backport ("prepatch") can take longer. |
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_Blog.php
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_Blog.php
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Outdated
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_ApiUpload.php
Show resolved
Hide resolved
Documentation/ExtensionArchitecture/Extbase/Reference/_FileUpload/_BlogEnhanced.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Frömken <froemken@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work 👍 I only added a single comment, that we should note, that domain model nesting is not supported. But this can also be added afterwards.
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
Further discussion in follow-up, we want to get this wrapped up as a first step to ease discussion
Documentation/ExtensionArchitecture/Extbase/Reference/FileUpload.rst
Outdated
Show resolved
Hide resolved
This backports PR #4808 for TYPO3 v12 and hints at the v13 changes only.
The first section about the history is "new content".
Starting with "_extbase_fileupload_attribute" the rest is taken from the well-written Changelog entry.
Closes TYPO3-Documentation/Changelog-To-Doc#1040
Note: Needs manual 12.4 backporting to reduce some of the info.
Releases: main, 12.4