Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Document Extbase FileUpload #4808

Merged
merged 17 commits into from
Oct 14, 2024
Merged

[TASK] Document Extbase FileUpload #4808

merged 17 commits into from
Oct 14, 2024

Conversation

garvinhicking
Copy link
Contributor

@garvinhicking garvinhicking commented Oct 9, 2024

The first section about the history is "new content".

Starting with "_extbase_fileupload_attribute" the rest is taken from the well-written Changelog entry.

Closes TYPO3-Documentation/Changelog-To-Doc#1040

Note: Needs manual 12.4 backporting to reduce some of the info.

Releases: main, 12.4

The first section about the history is "new content".

Starting with "_extbase_fileupload_attribute" the rest
is taken from the well-written Changelog entry.

Closes TYPO3-Documentation/Changelog-To-Doc#1040

Releases: main, 12.4
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write "Domain Model" lowercase, like written here:
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/Domain/Model.html#introduction

Additionally, you wrote sometimes "Domain Model" and sometimes "domain model".

I just checked the first part. The last part I'll do later.

garvinhicking and others added 4 commits October 9, 2024 19:21
…ad.rst

Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
…ad.rst

Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
remove "easy/easily"
Domain Model -> domain model
@brotkrueml
Copy link
Contributor

Do you really want to backport it to 12.4? Mostly it is about 13?

Copy link
Contributor Author

@garvinhicking garvinhicking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adressed the changes by @derhansen and @brotkrueml

@garvinhicking
Copy link
Contributor Author

Do you really want to backport it to 12.4? Mostly it is about 13?

A manual backport, yes. I want to keep the first section and then only hint at the v13 change. I didn't have time enough to split this up into a pre-patch because I need this for v13, and the backport ("prepatch") can take longer.

Co-authored-by: Stefan Frömken <froemken@gmail.com>
Copy link
Contributor

@derhansen derhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work 👍 I only added a single comment, that we should note, that domain model nesting is not supported. But this can also be added afterwards.

@linawolf linawolf added backport-required needs cherry-pick into other branches and removed backport 12.4 Backport to TYPO3v12 labels Oct 14, 2024
@garvinhicking garvinhicking dismissed brotkrueml’s stale review October 14, 2024 08:44

Further discussion in follow-up, we want to get this wrapped up as a first step to ease discussion

@garvinhicking garvinhicking merged commit 89f511e into main Oct 14, 2024
11 checks passed
@garvinhicking garvinhicking deleted the extbase-upload branch October 14, 2024 10:23
garvinhicking added a commit that referenced this pull request Oct 14, 2024
This backports PR #4808 for TYPO3 v12 and hints at the v13
changes only.
garvinhicking added a commit that referenced this pull request Oct 14, 2024
* [BACKPORT] [TASK] Backport Extbase FileUpload for v12 (#4808)

This backports PR #4808 for TYPO3 v12 and hints at the v13
changes only.

* [TASK] CGL

* [TASK] Use a "hint" instead of "versionchanged"
@linawolf linawolf added backport-done and removed backport-required needs cherry-pick into other branches labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Introduce Extbase file upload and deletion handling
5 participants