Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GUI inline edit errors for MySQL and CLI for MySQL, MariaDB, Oracle, Db2 #725

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

sm-shaw
Copy link
Contributor

@sm-shaw sm-shaw commented Jul 12, 2024

Issue only occurs in all cases when selecting both connect pool and asynch at the same time.
Verified that SQL Server implementation was not affected by the issue in CLI.
Issue is CLI index is character based but GUI is line.character therefore -1 moves back 1 line in GUI but only back 1 character in CLI.
We can identify the index by string is entier and correct the replacement in the GUI by not moving forward a line.

             set syncdrvi(3b) [ expr $syncdrvi(3b) - 1 ]
            #Delete run loop
	      if { [ string is entier $syncdrvi(3b) ] } {
            #CLI
            .ed_mainFrame.mainwin.textFrame.left.text fastdelete $syncdrvi(3a) $syncdrvi(3b)
                } else {
            #GUI
            .ed_mainFrame.mainwin.textFrame.left.text fastdelete $syncdrvi(3a) $syncdrvi(3b)+1l
                }

@sm-shaw sm-shaw requested a review from a team as a code owner July 12, 2024 11:36
@sm-shaw
Copy link
Contributor Author

sm-shaw commented Jul 12, 2024

Correction to the above in that we can identify the index by string is entier and correct the replacement in the CLI (not GUI) by not moving forward a line.
In the CLI we simulate the text editor that is already built into the GUI with string commands.

@abondvt89
Copy link
Contributor

Merging after reviews and approval of the three members of the code maintenance team.

@abondvt89 abondvt89 merged commit 90a5945 into TPC-Council:master Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants