Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doNotBelongToAnyOf(..) to syntax #422

Merged

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Sep 9, 2020

We have belongToAnyOf(), but the inverted form (doesNotBelongToAnyOf()) is missing and I couldn't find any easy way to just invert this in my ArchUnit invocations, so I concluded that perhaps it would make sense to add this to the framework proper?

The Javadocs are not really that great; feel free to suggest alternative wordings there. To the best of my knowledge, all tests should succeed including the tests for the functionality being added here.

@perlun perlun force-pushed the feature/add-does-not-belong-to-any-predicate branch from 90d34a0 to d637fce Compare September 9, 2020 11:28
@perlun perlun force-pushed the feature/add-does-not-belong-to-any-predicate branch from d637fce to 6c44ff0 Compare September 9, 2020 11:29
@perlun perlun force-pushed the feature/add-does-not-belong-to-any-predicate branch from 6c44ff0 to 9660a3d Compare September 9, 2020 11:35
@codecholeric codecholeric force-pushed the feature/add-does-not-belong-to-any-predicate branch from 9660a3d to d3e6237 Compare November 6, 2020 10:17
@codecholeric
Copy link
Collaborator

Thanks a lot for helping with this! And please excuse me, that it took me such a long time to look into your PR 😞
It all looks very good, I just have one suggestion regarding your additional DoesNotBelongToAnyOfPredicate. I think we can simply negate the existing predicate using the standard ArchUnit predicates "toolbox"
I added a simple review commit to demonstrate this. Does this look good to you? If yes, feel free to squash my commit onto yours and force push to have one neat commit for eternity 😉

@codecholeric codecholeric force-pushed the feature/add-does-not-belong-to-any-predicate branch from d3e6237 to 9cd946c Compare November 6, 2020 10:51
@codecholeric
Copy link
Collaborator

Did you get a chance to look into this?

@perlun
Copy link
Contributor Author

perlun commented Dec 8, 2020

Ah, sorry for the delay. Will try to get this sorted now.

@perlun perlun force-pushed the feature/add-does-not-belong-to-any-predicate branch from 9cd946c to b25e2f8 Compare December 8, 2020 08:49
@perlun
Copy link
Contributor Author

perlun commented Dec 8, 2020

Ah, sorry for the delay. Will try to get this sorted now.

@codecholeric Squashed into one nice little commit now, should be up for final review. Again, sorry for the unnecessary delay from my part on this one. 🙈

@perlun perlun force-pushed the feature/add-does-not-belong-to-any-predicate branch from b25e2f8 to 96a656f Compare December 8, 2020 09:08
@codecholeric
Copy link
Collaborator

No worries, it took me long enough to review your stuff, I'm certainly not gonna bitch if you need a little time 😂 I guess there are still some tests failing, but I'll fix them up and merge this then 👍
Thanks again for your contribution 😃 I really appreciate it!!

@codecholeric codecholeric force-pushed the feature/add-does-not-belong-to-any-predicate branch from 96a656f to fb91761 Compare December 14, 2020 20:52
Signed-off-by: Per Lundberg <per.lundberg@hibox.tv>
@codecholeric codecholeric force-pushed the feature/add-does-not-belong-to-any-predicate branch from fb91761 to 64acfbf Compare December 14, 2020 21:13
@codecholeric codecholeric changed the title Add doesNotBelongToAnyOf() conjuction method add doNotBelongToAnyOf(..) to syntax Dec 14, 2020
@codecholeric codecholeric merged commit 23b462c into TNG:master Dec 14, 2020
@perlun perlun deleted the feature/add-does-not-belong-to-any-predicate branch December 15, 2020 09:33
codecholeric added a commit that referenced this pull request Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants