-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doNotBelongToAnyOf(..) to syntax #422
add doNotBelongToAnyOf(..) to syntax #422
Conversation
90d34a0
to
d637fce
Compare
archunit/src/test/java/com/tngtech/archunit/core/domain/JavaClassTest.java
Outdated
Show resolved
Hide resolved
d637fce
to
6c44ff0
Compare
archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClass.java
Outdated
Show resolved
Hide resolved
6c44ff0
to
9660a3d
Compare
9660a3d
to
d3e6237
Compare
Thanks a lot for helping with this! And please excuse me, that it took me such a long time to look into your PR 😞 |
d3e6237
to
9cd946c
Compare
Did you get a chance to look into this? |
Ah, sorry for the delay. Will try to get this sorted now. |
9cd946c
to
b25e2f8
Compare
@codecholeric Squashed into one nice little commit now, should be up for final review. Again, sorry for the unnecessary delay from my part on this one. 🙈 |
b25e2f8
to
96a656f
Compare
No worries, it took me long enough to review your stuff, I'm certainly not gonna bitch if you need a little time 😂 I guess there are still some tests failing, but I'll fix them up and merge this then 👍 |
96a656f
to
fb91761
Compare
Signed-off-by: Per Lundberg <per.lundberg@hibox.tv>
fb91761
to
64acfbf
Compare
We have
belongToAnyOf()
, but the inverted form (doesNotBelongToAnyOf()
) is missing and I couldn't find any easy way to just invert this in my ArchUnit invocations, so I concluded that perhaps it would make sense to add this to the framework proper?The Javadocs are not really that great; feel free to suggest alternative wordings there. To the best of my knowledge, all tests should succeed including the tests for the functionality being added here.