Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component type to JavaClass dependencies #257

Closed
codecholeric opened this issue Nov 3, 2019 · 0 comments · Fixed by #428
Closed

Add component type to JavaClass dependencies #257

codecholeric opened this issue Nov 3, 2019 · 0 comments · Fixed by #428

Comments

@codecholeric
Copy link
Collaborator

Now that #244 has been merged, we should add the component type of an array as a dependency to JavaClass.
For example

class Example {
    Dependency[] dependencies;
}

At the moment this would count Example to have a dependency on Dependency[], but it would not yet report a dependency on Dependency, even though that is obviously present as well.

Note that in reality this is not a huge issue, because if no other dependency on Dependency arises anywhere, it pretty much means that we only have the array, but never actually do anything with the elements of type Dependency, thus the dependency is a very lose one.

Nevertheless, now that we have easy access to the component type, it should be well possible to extend the dependencies to cover all component types of all array type depedencies.

@codecholeric codecholeric added this to the 1.0.0 milestone Nov 3, 2019
jjank added a commit to jjank/ArchUnit that referenced this issue Sep 25, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
jjank added a commit to jjank/ArchUnit that referenced this issue Sep 25, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
jjank added a commit to jjank/ArchUnit that referenced this issue Sep 30, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
hankem added a commit to jjank/ArchUnit that referenced this issue Oct 29, 2020
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
jjank added a commit to jjank/ArchUnit that referenced this issue Oct 30, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
codecholeric pushed a commit to jjank/ArchUnit that referenced this issue Nov 15, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
codecholeric pushed a commit to jjank/ArchUnit that referenced this issue Nov 15, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
codecholeric pushed a commit to jjank/ArchUnit that referenced this issue Nov 15, 2020
This resolves parts of TNG#255 and adds the component type of arrays to the dependencies from self in JavaClass

Issue: TNG#255
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
jjank added a commit to jjank/ArchUnit that referenced this issue Nov 23, 2020
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
jjank added a commit to jjank/ArchUnit that referenced this issue Nov 23, 2020
Signed-off-by: Johannes Wengert <johannes.wengert@googlemail.com>
codecholeric added a commit that referenced this issue Dec 6, 2020
This PR partly resolves #257 by adding the component type of arrays to the dependencies *from self* in `JavaClass`.
codecholeric added a commit that referenced this issue Feb 21, 2021
This PR partly resolves #257 by adding the component type of arrays to the dependencies *from self* in `JavaClass`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant