Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/linter #7

Closed
wants to merge 189 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
189 commits
Select commit Hold shift + click to select a range
8ffcb6b
Reapply "Merge pull request #35045 from callstack-internal/issues/30123"
pac-guerreiro Jun 3, 2024
e81675e
fix: unreachable form inputs
pac-guerreiro Jun 3, 2024
d039eb0
chore: disable typescript rule for constant
pac-guerreiro Jun 3, 2024
12dc2c6
fix If we alter transaction details, new message green line disappears
tienifr Jun 6, 2024
89492f6
Merge branch 'main' into issues/30123
pac-guerreiro Jun 11, 2024
cab7692
Merge branch 'main' into issues/30123
pac-guerreiro Jun 11, 2024
7257198
Merge branch 'main' into issues/30123
pac-guerreiro Jun 11, 2024
838218d
fix: hiding submit button on address search screen
pac-guerreiro Jun 11, 2024
6b11184
refactor: remove unnecessary code and comments
pac-guerreiro Jun 12, 2024
ea52a61
Merge branch 'main' into issues/30123
pac-guerreiro Jun 12, 2024
30c08c8
allow displaying default rooms with empty participants when searching…
jasperhuangg Jun 12, 2024
fbb2d4a
refactor: apply suggestion
pac-guerreiro Jun 13, 2024
bb1dff8
Merge branch 'main' into issues/30123
pac-guerreiro Jun 13, 2024
748ffec
fix merge main
tienifr Jun 17, 2024
e85e860
Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…
jasperhuangg Jun 17, 2024
72e3f6d
add comment
jasperhuangg Jun 17, 2024
76b6469
style
jasperhuangg Jun 17, 2024
57d3356
prevent rooms from getting filtered out during participantLogins/disp…
jasperhuangg Jun 17, 2024
932b8ce
style
jasperhuangg Jun 17, 2024
1464ba1
ensure chat rooms don't get filtered out in the front-end if they don…
jasperhuangg Jun 17, 2024
e8cae10
update comment
jasperhuangg Jun 17, 2024
acc477f
remove unused
jasperhuangg Jun 17, 2024
4d5b18b
Use suitable decimals while calculating tax
ShridharGoel Jun 18, 2024
1b3a5ef
Merge branch 'main' into issues/30123
pac-guerreiro Jun 19, 2024
6f1994e
refactor: remove unnecessary styles
pac-guerreiro Jun 19, 2024
941748d
Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…
jasperhuangg Jun 21, 2024
978ad3b
prevent all chat rooms from being searchable by participant
jasperhuangg Jun 21, 2024
3e6b24e
Allow empty rooms to show up when searching
jasperhuangg Jun 21, 2024
6aebea1
remove debug logs
jasperhuangg Jun 24, 2024
d0fb81d
remove debug logs
jasperhuangg Jun 24, 2024
76f675d
update comment
jasperhuangg Jun 24, 2024
fe894c6
fix: Categorizing - RHP closes instead of returning to category list …
Krishna2323 Jun 25, 2024
875bf49
Merge branch 'main' into issues/30123
pac-guerreiro Jun 25, 2024
0a17153
fix: address suggestions list not scrollable on web
pac-guerreiro Jun 25, 2024
d03daf4
Update
ShridharGoel Jun 25, 2024
f1b4060
Add and update tests
ShridharGoel Jun 25, 2024
69e2c0c
Merge branch 'main' of https://github.com/Expensify/App into max-tax
ShridharGoel Jun 25, 2024
c362173
Update IOURequestStepDistanceRate.tsx
ShridharGoel Jun 25, 2024
acb273f
merge conflicts
jasperhuangg Jun 25, 2024
e89431e
Update
ShridharGoel Jun 26, 2024
9443aaa
Merge branch 'max-tax' of https://github.com/ShridharGoel/ExpensifyAp…
ShridharGoel Jun 26, 2024
f6d8de6
Update
ShridharGoel Jun 26, 2024
2a7588d
Update
ShridharGoel Jun 26, 2024
e07f641
Merge branch 'main' into issues/30123
pac-guerreiro Jun 26, 2024
a5d2f9b
refactor: fix linter issues
pac-guerreiro Jun 26, 2024
69ac6d2
fix: negate amount for expense report
dominictb Jun 26, 2024
0333496
Merge branch 'main' into issues/30123
pac-guerreiro Jun 26, 2024
f1c0d53
refactor: fix prettier issues
pac-guerreiro Jun 26, 2024
a5b70cc
Flip searchable via participants conditions
jasperhuangg Jun 26, 2024
baad6f9
Add comment for confusing section
jasperhuangg Jun 26, 2024
e379688
Fix text input won't auto focus after back from get assistance page i…
tsa321 Jun 26, 2024
c7fc9ab
fix merge main
tienifr Jun 27, 2024
a56370d
fix: suggestions not wrapping inside row
pac-guerreiro Jun 27, 2024
0237f81
calculate isSearchingForReports from searchInputValue
jasperhuangg Jun 27, 2024
a842879
simplify logic and improve comment
jasperhuangg Jun 27, 2024
128a3ce
update comment
jasperhuangg Jun 27, 2024
8b49913
Replace capitalised "s" in the "Account settings"
devguest07 Jun 27, 2024
dfead13
style
jasperhuangg Jun 28, 2024
01c993f
remove unused
jasperhuangg Jun 28, 2024
d42b35b
add back missing variable
jasperhuangg Jun 28, 2024
13eb028
Merge branch 'main' into issues/30123
pac-guerreiro Jun 28, 2024
fdadd5f
fix: scrolling issues
pac-guerreiro Jun 28, 2024
ecf4bfe
remove unused logic
jasperhuangg Jun 28, 2024
1835257
improve comment
jasperhuangg Jun 28, 2024
edcb7ef
remove unused comment
jasperhuangg Jun 28, 2024
131ae67
Use isChatRoom to decide whether to display reports with empty partic…
jasperhuangg Jun 28, 2024
a133dde
remove unused
jasperhuangg Jun 28, 2024
8e0ca90
remove unused
jasperhuangg Jun 28, 2024
09870fc
remove unused
jasperhuangg Jun 28, 2024
7c12483
simplify logic
jasperhuangg Jun 28, 2024
cae1a80
remove isSearchableViaParticipants
jasperhuangg Jun 28, 2024
a202b1e
remove unused
jasperhuangg Jun 28, 2024
88a6564
add missing hook dependency
jasperhuangg Jun 28, 2024
802a3d0
remove unused param
jasperhuangg Jun 28, 2024
f6f13a4
Fix: After inviting a member navigating back takes you back to member…
truph01 Jul 1, 2024
4b55bd9
fix: Design updates to Search rows on mobile
dominictb Jul 1, 2024
814baa7
fix: lint
dominictb Jul 1, 2024
d686ba9
Fix: Remove comment
truph01 Jul 1, 2024
9ca7cea
remove duplicate checks
jasperhuangg Jul 1, 2024
d1c6c00
condense logic and add comment
jasperhuangg Jul 1, 2024
9e4ab91
Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…
jasperhuangg Jul 1, 2024
f5dc4f7
remove unused
jasperhuangg Jul 1, 2024
a72642a
make merchant optional in invoice
bernhardoj Jul 2, 2024
36b4b23
Implement Parser
blazejkustra Jul 2, 2024
2947064
Disallow importing ExpeniMark
blazejkustra Jul 2, 2024
1912a36
Ignore ExpeniMark import
blazejkustra Jul 2, 2024
00b1c98
Change usage of OnyxAwareParser
blazejkustra Jul 2, 2024
01e3d01
set the logger in PArser lib
blazejkustra Jul 2, 2024
69bafc7
Remove all ExpeniMark imports and use PArser instead
blazejkustra Jul 2, 2024
a4d0160
Add eslint disable for storybook ExpeniMark import
blazejkustra Jul 2, 2024
27c9233
Merge branch 'main' into issues/30123
pac-guerreiro Jul 2, 2024
785a45f
fix: predefined places being filtered in offline mode
pac-guerreiro Jul 2, 2024
fc42693
fix: update isLoading logic on workspace catogory page
dominictb Jul 3, 2024
55feafb
render mapview when access token is set in a library
TMisiukiewicz Jul 3, 2024
4ebb8f6
fix lint
TMisiukiewicz Jul 3, 2024
a9b73ca
Merge branch 'main' into refactor/centralize-expensimark
blazejkustra Jul 3, 2024
f8352cb
Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…
jasperhuangg Jul 3, 2024
a90fe8f
fix: Web - Profile - Hovering over the zoom tool does not display a t…
Krishna2323 Jul 3, 2024
505e31a
consolidate logic
jasperhuangg Jul 3, 2024
86735ab
consolidate logic
jasperhuangg Jul 3, 2024
6bc5b48
Fix: Merge main
dominictb Jul 4, 2024
c1b0ddb
Fix: Category styles
dominictb Jul 4, 2024
aba4a1b
Fix: Update passing isLargeScreenWidth logic
dominictb Jul 4, 2024
e08b275
Merge branch 'main' into refactor/centralize-expensimark
blazejkustra Jul 4, 2024
3643497
Merge branch 'Expensify:main' into 43923
devguest07 Jul 4, 2024
9569e75
Merge branch 'main' of https://github.com/Expensify/App into max-tax
ShridharGoel Jul 4, 2024
ead5591
Update
ShridharGoel Jul 4, 2024
21530f8
Update IOURequestStepTaxRatePage.tsx
ShridharGoel Jul 4, 2024
2fb7b26
Add some default values
ShridharGoel Jul 4, 2024
6d4d7aa
Merge branch 'max-tax' of https://github.com/ShridharGoel/ExpensifyAp…
ShridharGoel Jul 4, 2024
6747545
Lint fix
ShridharGoel Jul 4, 2024
4920a65
Merge branch 'main' into issues/30123
pac-guerreiro Jul 4, 2024
0b5bbe3
Revert "fix: predefined places being filtered in offline mode"
pac-guerreiro Jul 4, 2024
363ab6f
fix: address search not showing recent waypoints while offline
pac-guerreiro Jul 4, 2024
d47954a
merge main
dominictb Jul 5, 2024
f05fff3
Typecheck fix
ShridharGoel Jul 5, 2024
d6f9056
remove view button in mobile and display one line merchant
dominictb Jul 5, 2024
f8df4cf
fix lint
dominictb Jul 5, 2024
6ea6286
Update
ShridharGoel Jul 5, 2024
c2d7b70
Implemented remaining pages of NetSuite Advanced
shubham1206agra Jul 5, 2024
35eee59
Bug fix
shubham1206agra Jul 5, 2024
acfa474
Small bugfix in API
shubham1206agra Jul 5, 2024
f7b2940
Small bugfix in Custom Form ID API
shubham1206agra Jul 5, 2024
bea76a8
Fixing style of form
shubham1206agra Jul 5, 2024
72785fd
Fixing style
shubham1206agra Jul 5, 2024
db546d9
Update
ShridharGoel Jul 6, 2024
299a42e
mWeb/Safari - Attachments - New tab doesn't open when clicking the do…
Krishna2323 Jul 6, 2024
7a4fdd9
now clicking same link will keep you at same place
rushatgabhane Jul 6, 2024
72a58fd
Addressing comments
shubham1206agra Jul 7, 2024
7adc3bc
Adding validation to custom form ID
shubham1206agra Jul 7, 2024
57320ef
Fixing API call
shubham1206agra Jul 7, 2024
5b489bd
Merge branch 'main' into fix/mapbox-initialization
TMisiukiewicz Jul 8, 2024
d7a15e5
Merge branch 'main' into refactor/centralize-expensimark
blazejkustra Jul 8, 2024
2eac47e
Bump react-native-onyx to 2.0.56
fabioh8010 Jul 8, 2024
6c32800
Change ExpensiMark usage to Parser
blazejkustra Jul 8, 2024
5570f03
Merge branch 'main' into refactor/centralize-expensimark
blazejkustra Jul 8, 2024
9a7e853
Update en.ts
jamesdeanexpensify Jul 8, 2024
42c6229
Update es.ts
jamesdeanexpensify Jul 8, 2024
b6c743b
Correct bad spanish translation
iwiznia Jul 8, 2024
b214e77
Merge pull request #44961 from Expensify/ionatan_correctbadtranslation
nkuoch Jul 8, 2024
e0ccba5
Merge pull request #44950 from fabioh8010/feature/bump-onyx-2.0.56
thienlnam Jul 8, 2024
9b47620
feat: react-compiler healthcheck
kirillzyusko Jun 26, 2024
467ec27
fix: ignore react-compiler violations
kirillzyusko Jun 28, 2024
6ba51f9
fix: last eslint violation
kirillzyusko Jun 30, 2024
19b1b5b
chore: bump react-compiler version
kirillzyusko Jul 4, 2024
75abab0
fix: changes after rebase
kirillzyusko Jul 5, 2024
3a88493
Fix missing title and details in report details page
ShridharGoel Jul 8, 2024
596e569
Apply suggestions from code review
shubham1206agra Jul 8, 2024
21e60d4
fix text colour
Julesssss Jul 8, 2024
9d452e1
Merge pull request #44973 from ShridharGoel/patch-9
Julesssss Jul 8, 2024
7ba4d70
Update version to 9.0.5-4
OSBotify Jul 8, 2024
e7a46a5
Merge pull request #44976 from Expensify/jules-textColourFix
Julesssss Jul 8, 2024
2bf0359
Merge pull request #44954 from Expensify/jamesdeanexpensify-patch-1
thienlnam Jul 8, 2024
91df51c
fix: Country field reverts to the previous selection
nkdengineer Jul 8, 2024
3323b75
Update Admin-Card-Settings-and-Features.md
maddylewis Jul 8, 2024
8540bcf
Merge pull request #44677 from dominictb/fix/44563
luacmartins Jul 8, 2024
547336d
Merge pull request #44982 from Expensify/maddylewis-patch-1
pecanoro Jul 8, 2024
c5c4ea8
Merge pull request #44668 from truph01/fix/44035
thienlnam Jul 8, 2024
11b56c4
Applying suggestions
shubham1206agra Jul 8, 2024
31d0194
fix merge conflicts
jasperhuangg Jul 8, 2024
0c68e38
Applying suggestions
shubham1206agra Jul 8, 2024
2354386
Merge pull request #44921 from shubham1206agra/netsuite-advanced-2
yuwenmemon Jul 8, 2024
6acc21c
Merge pull request #43626 from Expensify/jasper-defaultRoomsEmptyPart…
jasperhuangg Jul 8, 2024
7fd501d
Merge pull request #44936 from rushatgabhane/help-lhn-fix
NikkiWines Jul 8, 2024
ef87b58
Update Cardholder-Settings-and-Features.md
maddylewis Jul 8, 2024
da24e9a
Merge pull request #44933 from Krishna2323/krishna2323/issue/43857
srikarparsi Jul 8, 2024
c98b754
Merge pull request #44766 from dominictb/fix/44224-policy-ctg
srikarparsi Jul 8, 2024
58db389
Merge pull request #44413 from Krishna2323/krishna2323/issue/43616
francoisl Jul 8, 2024
d2b5315
Merge pull request #44439 from dominictb/fix/42325-neg-amt
blimpich Jul 8, 2024
4a3ecb3
Merge pull request #44981 from nkdengineer/fix/44957
mountiny Jul 8, 2024
9dccffe
Merge pull request #44767 from callstack-internal/fix/mapbox-initiali…
deetergp Jul 8, 2024
608cd99
Merge pull request #43948 from ShridharGoel/max-tax
francoisl Jul 8, 2024
55585f0
Merge branch 'Expensify:main' into 43923
devguest07 Jul 8, 2024
d1c801a
Merge pull request #44574 from devguest07/43923
francoisl Jul 8, 2024
a5fb7cd
Merge pull request #44721 from bernhardoj/fix/44126-merchant-is-requi…
cristipaval Jul 8, 2024
fe2fcf0
Merge pull request #44460 from margelo/feat/react-compiler-healthcheck
mountiny Jul 8, 2024
fb7fe9f
Update version to 9.0.5-5
OSBotify Jul 8, 2024
3dbbd2a
Skip react compiler
mountiny Jul 8, 2024
b080461
Merge pull request #44996 from Expensify/maddylewis-patch-1
carlosmiceli Jul 8, 2024
4e1470b
Merge pull request #45012 from Expensify/vit-20240708lint
mountiny Jul 8, 2024
29e8df5
Merge pull request #43011 from callstack-internal/issues/30123
neil-marcellini Jul 8, 2024
b419c06
Merge pull request #44732 from software-mansion-labs/refactor/central…
neil-marcellini Jul 8, 2024
15e67a0
Merge pull request #44788 from Krishna2323/krishna2323/issue/44029
neil-marcellini Jul 8, 2024
70d892a
merge main and resolve conflict
tsa321 Jul 9, 2024
7b558ef
Merge pull request #43162 from tienifr/fix/41211
srikarparsi Jul 9, 2024
dd96852
Merge pull request #44511 from tsa321/inviteMemberFocusBug
srikarparsi Jul 9, 2024
f9353cb
lint only changed files
TMisiukiewicz Jul 9, 2024
ddf81c4
test change in file
TMisiukiewicz Jul 9, 2024
cba106e
update ci to npx
TMisiukiewicz Jul 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const restrictedImportPaths = [
'',
"For 'useWindowDimensions', please use '@src/hooks/useWindowDimensions' instead.",
"For 'TouchableOpacity', 'TouchableWithoutFeedback', 'TouchableNativeFeedback', 'TouchableHighlight', 'Pressable', please use 'PressableWithFeedback' and/or 'PressableWithoutFeedback' from '@components/Pressable' instead.",
"For 'StatusBar', please use '@src/libs/StatusBar' instead.",
"For 'StatusBar', please use '@libs/StatusBar' instead.",
"For 'Text', please use '@components/Text' instead.",
"For 'ScrollView', please use '@components/ScrollView' instead.",
].join('\n'),
Expand Down Expand Up @@ -59,8 +59,12 @@ const restrictedImportPaths = [
},
{
name: 'expensify-common',
importNames: ['Device'],
message: "Do not import Device directly, it's known to make VSCode's IntelliSense crash. Please import the desired module from `expensify-common/dist/Device` instead.",
importNames: ['Device', 'ExpensiMark'],
message: [
'',
"For 'Device', do not import it directly, it's known to make VSCode's IntelliSense crash. Please import the desired module from `expensify-common/dist/Device` instead.",
"For 'ExpensiMark', please use '@libs/Parser' instead.",
].join('\n'),
},
];

Expand Down Expand Up @@ -94,6 +98,7 @@ module.exports = {
'plugin:@typescript-eslint/stylistic-type-checked',
'plugin:you-dont-need-lodash-underscore/all',
'prettier',
"plugin:diff/ci"
],
plugins: ['@typescript-eslint', 'jsdoc', 'you-dont-need-lodash-underscore', 'react-native-a11y', 'react', 'testing-library', 'eslint-plugin-react-compiler'],
ignorePatterns: ['lib/**'],
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ jobs:
uses: ./.github/actions/composite/setupNode

- name: Lint JavaScript and Typescript with ESLint
run: npm run lint
run: npx --no-install eslint --ext .js,.jsx,.ts,.tsx .
env:
ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }}
CI: true

- name: Verify there's no Prettier diff
Expand Down
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1009000503
versionName "9.0.5-3"
versionCode 1009000505
versionName "9.0.5-5"
// Supported language variants must be declared here to avoid from being removed during the compilation.
// This also helps us to not include unnecessary language variants in the APK.
resConfigs "en", "es"
Expand Down
18 changes: 9 additions & 9 deletions docs/_includes/lhn-template.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,25 @@
{% for platform in site.data.routes.platforms %}
{% if platform.href == activePlatform %}
<li>
<a href="/" class="icon-with-link selected">
<img src="/assets/images/down.svg" class="base-icon"></img>
<div class="icon-with-link selected">
<a href="/"><img src="/assets/images/down.svg" class="base-icon"></img></a>
<span>{{ platform.title }}</span>
</a>
</div>
{% for hub in platform.hubs %}
<ul>
{% if hub.href == activeHub %}
<a href="/{{ activePlatform }}/hubs/" class="icon-with-link selected">
<img src="/assets/images/down.svg" class="base-icon"></img>
<div class="icon-with-link selected">
<a href="/{{ activePlatform }}/hubs"><img src="/assets/images/down.svg" class="base-icon"></img></a>
<span>{{ hub.title }}</span>
</a>
</div>
<ul class="nested-treeview">
{% for section in hub.sections %}
<li>
{% if section.href == activeSection %}
<a href="/{{ activePlatform }}/hubs/{{ hub.href }}" class="icon-with-link selected">
<img src="/assets/images/down.svg" class="base-icon"></img>
<div class="icon-with-link selected">
<a href="/{{ activePlatform }}/hubs/{{ hub.href }}"><img src="/assets/images/down.svg" class="base-icon"></img></a>
<span>{{ section.title }}</span>
</a>
</div>
<ul>
{% for article in section.articles %}
{% assign article_href = section.href | append: '/' | append: article.href %}
Expand Down
1 change: 1 addition & 0 deletions docs/_sass/_main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,7 @@ button {
width: 20px;
height: 20px;
cursor: pointer;
display: inline-block;
}

.homepage {
Expand Down
Loading
Loading