forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/migrate to biome #6
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/dupe-detection-review-fields
…-questions Fix/44462 show idology questions
…egrate-retry-billing-with-be
…ture/43684-report-fields-creating-flow-4
merge main into @cdOut/money-report-rename
merge main into @cdOut/three-dot-removal
…-hold Disallow holding expenses on closed reports
merge main into trip-corrected/trip-receipt
No more beta step for GR
[CP Staging] Revert "Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace"
…ction-review-fields Feat/Dupe detection review fields
fix: dismiss violation action in review duplication feat
…mands Add new read commands for the workspace profile and initial settings pages - v2
…765-fix-animation-rhp fix RHP animation on Safari
…e-upgrade Add workspace upgrade flow
…rom-main-report-action-context-menu Hide disabled actions from main secondary interaction (right click/long tap) report action context menu for System chats
…/44869 fix: Category - Disabled parent category is not grayed out in the list.
*Total -- 1,285.88kb -> 1,085.92kb (15.55%) /docs/assets/images/ExpensifyHelp-QBO-2.png -- 228.04kb -> 180.79kb (20.72%) /docs/assets/images/ExpensifyHelp-Invoice-1.png -- 357.83kb -> 294.48kb (17.7%) /docs/assets/images/ExpensifyHelp-QBO-1.png -- 154.13kb -> 131.67kb (14.57%) /docs/assets/images/ExpensifyHelp-QBO-4.png -- 184.60kb -> 159.82kb (13.43%) /docs/assets/images/ExpensifyHelp-QBO-3.png -- 180.13kb -> 156.19kb (13.29%) /docs/assets/images/ExpensifyHelp-QBO-5.png -- 104.64kb -> 91.29kb (12.75%) /assets/images/expensifyCard/cardIllustration.svg -- 42.50kb -> 38.95kb (8.36%) /assets/images/integrationicons/sage-intacct-icon-square.svg -- 2.22kb -> 2.06kb (7.08%) /assets/images/integrationicons/netsuite-icon-square.svg -- 5.32kb -> 5.12kb (3.73%) /assets/images/computer.svg -- 26.48kb -> 25.56kb (3.47%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
…lds-delete-flow Feature: Implement the policy report field delete flow
…e-report-old-chat-messages-stays-in-chat One-expense-report old chat messages stays in chat
d277cf0
to
59737a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop