🔨 Resolve prices.tf 401 issue

[idinium96]

Might fix the issue where the bot doesn't even bother to get new JWT from prices.tf. Quite ugly tbh.

[RobotoLev]

Reviewing it rn

[idinium96]

Hhmmmm something is wrong. It does not wait until one job is completed.

[idinium96]

Probably because of this... Let me try remove it

[idinium96]

hmmm kinda necessary tbh

[RobotoLev]

I had that situtation today, so I'm watching the log in order to make something more clear. I don't think that happens because of using try-catch instead of promise's .catch() thing.

[idinium96]

I had that situtation today, so I'm watching the log in order to make something more clear. I don't think that happens because of using try-catch instead of promise's .catch() thing.

It's okay I've found the problem. But now another problem came (but probably off-topic)

[idinium96]

Looks like this doesn't help either. It doesn't even update my dummy token.

[RobotoLev]

So as I thought, it just doesn't re-request token for some reason. I'm pretty sure all was fine when I was implementing fix for v4.13.1.

As I see in my Discord channel history, this strange 401 wasn't appearing on v4.13.1-v5.0.0, but appeared again at v5.0.1. I still don't know what might be reason for it, but that's the pure fact.

[idinium96]

So as I thought, it just doesn't re-request token for some reason. I'm pretty sure all was fine when I was implementing fix for v4.13.1.

As I see in my Discord channel history, this strange 401 wasn't appearing on v4.13.1-v5.0.0, but appeared again at v5.0.1. I still don't know what might be reason for it, but that's the pure fact.

For me, it started appearing on v4.11.0.
I think I am going to revert changes made in 3cbf725

[RobotoLev]

Wait a second. Can filterAxiosError change error format???

[RobotoLev]

You've probably cut off response from AxiosError, so catch doesn't re-request token.

[idinium96]

Wait a second. Can filterAxiosError change error format???

Ah dang, you're right. That might be the issue. 🤐

[RobotoLev]

That's definitely it. There's no err.response.status now (there's no err.response even), so bot thinks that it's non-standart error and drops it farther.

[idinium96]

That's definitely it. There's no err.response.status now (there's no err.response even), so bot thinks that it's non-standart error and drops it farther.

Let me try once again, and then again before this.

[idinium96]

Yeah... gonna try the old one.

[idinium96]

Oh god, the old one works just fine

[RobotoLev]

That's me who was implementing it (check v4.13.1). At that time 401 was handled well, so now I knew the problem is not here.

[joekiller]

Yeah I'd revert. Because the function expects a promise returned but nothing is happening but a void call who knows when it'll resolve. It is likely executing out of order. If you want to keep the new form (but using callbacks blah that's what async is for) you'd need to return the promise instead of executing it as a void

[idinium96]

That's me who was implementing it (check v4.13.1). At that time 401 was handled well, so now I knew the problem is not here.

Yeah, that was before the filterAxios thing.

[idinium96]

Yeah I'd revert. Because the function expects a promise returned but nothing is happening but a void call who knows when it'll resolve. It is likely executing out of order. If you want to keep the new form (but using callbacks blah that's what async is for) you'd need to return the promise instead of executing it as a void

Yeah gonna revert it now. Thank you :3

[idinium96]

Thank you @RobotoLev!
Feel free to approve this PR.