Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix high value items not checking for asset id price #1273

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

joekiller
Copy link
Collaborator

This ensures that high value items are entered into the getHighValue map with the appropriate price key

Copy link
Member

@idinium96 idinium96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I think this might cause an issue here, but if you have tested and it's all good, then I will merge this soon.

itemsWithName[bot.schema.getName(SKU.fromString(sku.replace(/;p\d+/, '')))] = toString;

@joekiller
Copy link
Collaborator Author

Thanks for the PR. I think this might cause an issue here, but if you have tested and it's all good, then I will merge this soon.

itemsWithName[bot.schema.getName(SKU.fromString(sku.replace(/;p\d+/, '')))] = toString;

Yeah it'll blow up if one item isn't on the pricelist while another is. lemme fix it up

@joekiller
Copy link
Collaborator Author

also fixed !find not working for pricelist entries with and id

image

@joekiller joekiller force-pushed the fix-selling-highvalue-priced-assetid branch from bbea3d5 to 28fde2f Compare August 1, 2022 03:35
@joekiller joekiller changed the base branch from master to development August 1, 2022 03:36
@joekiller joekiller force-pushed the fix-selling-highvalue-priced-assetid branch from 28fde2f to b4cbf16 Compare August 1, 2022 03:38
@joekiller joekiller force-pushed the fix-selling-highvalue-priced-assetid branch from b4cbf16 to 037d5ec Compare August 1, 2022 03:39
@joekiller
Copy link
Collaborator Author

okay I squashed and rebased onto development

Copy link
Member

@idinium96 idinium96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 👍

@idinium96 idinium96 merged commit 03c4daa into development Aug 1, 2022
@idinium96 idinium96 mentioned this pull request Aug 1, 2022
@idinium96 idinium96 deleted the fix-selling-highvalue-priced-assetid branch August 1, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants