Use native promises

[carloslbello]

Refactored the code to use native promises and remove a few dependencies.

[idinium96]

Thank you. I will have a look on this and solve the conflict once I'm back home.

[idinium96]

Works now.
Previously it just never initializes bptf-listings.

[idinium96]

Looks like the process is not terminated when there's an error on start, and it will just be stuck there indefinitely.
Please check for missing catch or throw. Should crash/terminate the process if there's an error while starting.

[idinium96]

Stopping the bot also does not immediately terminate the process while it's starting, like how it used to be.

[carloslbello]

I think returning the promise from the start function should fix the error handling issue. Just added a commit which does that.

[idinium96]

nah.

I think should have catch here.

tf2autobot/src/app.ts

Lines 144 to 152 in aaf13c5

	void (async () => {
	await botManager.start(options);
	if (options.enableHttpApi) {
	const { default: HttpManager } = await import('./classes/HttpManager');
	const httpManager = new HttpManager(options);
	await httpManager.start();
	}
	})();

.catch(err => throw err));

Or do try-catch method

[idinium96]

The process is still not terminated/crashed when there's an error on start.

[carloslbello]

Can you place a log statement before line 734 in src/classes/Bot.ts to see if the checkIfStopping function is being run after each promise in the chain?

[idinium96]

Sure thing. Let me try.
Also, if you want to use my extra account reserved for testing, just let me know.

[idinium96]

The old one should be here that will reject the start

tf2autobot/src/classes/Bot.ts

Lines 1028 to 1031 in f8f7c9a

	err => {
	if (err) {
	return reject(err);
	}

I am also not sure if using let promise = Promise.resolve(); is the right way to do or not.

[idinium96]

Maybe bring back

tf2autobot/src/classes/Bot.ts

Line 735 in f8f7c9a

return new Promise((resolve, reject) => {

tf2autobot/src/classes/BotManager.ts

Line 58 in f8f7c9a

return new Promise((resolve, reject) => {

and reject on error, so that it will catch the error in app.js

[carloslbello]

I am unable to reproduce these issues on my machine at the current commit. I tried with node v16.15.1 and node v18.4.0.

[idinium96]

If you're unable to reproduce the error, that means Steam is back alive.
Try adding a line that will throw an error anywhere in the promiseChains, like the one I previously did (the "nah." one)

[carloslbello]

I can't reproduce even when manually introducing an error - the code correctly shuts down upon erroring on my machine. See the attached mov file.

Screen.Recording.2022-06-19.at.7.47.42.PM.mov

[idinium96]

hhmmmm weird.

[idinium96]

Merging this into development.
Thank you very much!