Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WI-202: insert letsencrypt post-renewal hook after deploy #58

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

jarosenb
Copy link
Contributor

Adds a PLACE_RENEWAL_HOOK command that runs as part of the deploy-all process. This command places a script in /etc/letsencrypt/renewal-hooks/post/ with the following content and ensures that it is executable:

#! /bin/sh
${DOCKER_COMPOSE} restart nginx

We need to run the command within a docker container in order to escalate privileges and modify root-owned files in the /etc/letsencrypt directory.

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! NSO will be very happy.

Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@rstijerina rstijerina merged commit df8d5f5 into main Mar 3, 2025
@rstijerina rstijerina deleted the task/WI-202--letsencrypt-post-deploy branch March 3, 2025 16:20
jarosenb added a commit that referenced this pull request Mar 3, 2025
@jarosenb jarosenb restored the task/WI-202--letsencrypt-post-deploy branch March 3, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants