Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/remove public route #241

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Hotfix/remove public route #241

merged 5 commits into from
Mar 11, 2025

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Mar 5, 2025

Overview:

This PR includes the following updates:

  • Removes the public route
    • This route was originally a workaround for our deployed version of WS02, which did not allow us to configure a single route to support both credentialed and non-credentialed access. As a result, we had separate public-project and project routes. With this change, the workaround is no longer needed.
  • Resolves WG-192 and updates analytics-related headers
    • Addresses an issue related to TapisV3/WS02 where certain headers were not permitted. This update ensures that the necessary headers are used for analytics instead of query params.

Related Jira tickets:

  • WG-192
  • No ticket for public route removal but was a workaround for WSO2/tapisv2 limitations that we can now revert

Testing

  • Run this branch with hazmapper (Hotfix/remove public route hazmapper#340) and confirm that analytics logging is working for public maps, non-public maps and well not log in.
    • on react app
      • don't forget geoapiBackend: GeoapiBackendEnvironment.Local, and designSafePortal:DesignSafePortalEnvironment.PPRD in secret_local.ts
    • on angular app
      • don't forget backend: EnvironmentType.Local and designSafePortal: DesignSafeEnvironmentType.PPRD, in ../hazmapper/angular/src/environments/environment.ts
  • Do the same with taggit (task/WG-192: Update taggit to use headers for analytics taggit-tacc/taggit#143) - confirm that analytics work for maps (no public maps yet)
    • on angular app
    • don't forget backend: EnvironmentType.Local and designSafePortal: DesignSafeEnvironmentType.PPRD, in ../hazmapper/angular/src/environments/environment.ts

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nathanfranklin nathanfranklin merged commit b464e64 into main Mar 11, 2025
3 checks passed
@nathanfranklin nathanfranklin deleted the hotfix/remove-public-route branch March 11, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants