Skip to content

Commit

Permalink
[Bugfix] fix flaky test (vllm-project#13089)
Browse files Browse the repository at this point in the history
Signed-off-by: மனோஜ்குமார் பழனிச்சாமி <smartmanoj42857@gmail.com>
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
  • Loading branch information
SmartManoj authored and SzymonOzog committed Feb 12, 2025
1 parent f01d066 commit b22c419
Showing 1 changed file with 6 additions and 21 deletions.
27 changes: 6 additions & 21 deletions tests/test_seed_behavior.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,17 @@


def test_seed_behavior():
# Test with seed=None
Platform.seed_everything(None)
# Test with a specific seed
Platform.seed_everything(42)
random_value_1 = random.randint(0, 100)
np_random_value_1 = np.random.randint(0, 100)
torch_random_value_1 = torch.randint(0, 100, (1, )).item()

Platform.seed_everything(None)
Platform.seed_everything(42)
random_value_2 = random.randint(0, 100)
np_random_value_2 = np.random.randint(0, 100)
torch_random_value_2 = torch.randint(0, 100, (1, )).item()

assert random_value_1 != random_value_2
assert np_random_value_1 != np_random_value_2
assert torch_random_value_1 != torch_random_value_2

# Test with a specific seed
Platform.seed_everything(42)
random_value_3 = random.randint(0, 100)
np_random_value_3 = np.random.randint(0, 100)
torch_random_value_3 = torch.randint(0, 100, (1, )).item()

Platform.seed_everything(42)
random_value_4 = random.randint(0, 100)
np_random_value_4 = np.random.randint(0, 100)
torch_random_value_4 = torch.randint(0, 100, (1, )).item()

assert random_value_3 == random_value_4
assert np_random_value_3 == np_random_value_4
assert torch_random_value_3 == torch_random_value_4
assert random_value_1 == random_value_2
assert np_random_value_1 == np_random_value_2
assert torch_random_value_1 == torch_random_value_2

0 comments on commit b22c419

Please sign in to comment.