Implement burn from sender #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## xchain-pools #1622 +/- ##
================================================
+ Coverage 68.02% 71.95% +3.93%
================================================
Files 30 61 +31
Lines 663 788 +125
Branches 121 246 +125
================================================
+ Hits 451 567 +116
- Misses 179 188 +9
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. see 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbeal-eth
requested changes
May 25, 2023
dbeal-eth
approved these changes
May 26, 2023
barrasso
added a commit
that referenced
this pull request
Jul 7, 2023
* start on cross chain pools with cl functions * initial efforts edge cases identified and will be irioned out tomorrow. but this is most of the structure! * closer pre single chain tests * write out planned tests, rework a bit of the cross chain details starting to look just a bit ugly, hopefully getting pretty close to the end of the edge cases. we see! * add missing file * tests back to normal * add important debt check test * add some tests before I leave for vacation * minor fixes * more minor fixes * Run yarn lint:sol:fix * Run yarn lint:js:fix * Use CrossChain storage lib for cross chain usd transfers * fixes for utils module, allow xchain pools to have its own versioning * v3.2.0-xchain.0 * fix error * Implement burn from sender (#1622) * add burn from sender * call burn with target as caller * Add access check * add tests * fix lint * fix lint * fixes * first successful ccip send of createCrossChainPool next step: pool sync final step: pool config * fixes to load contract from misc source * Add transfer cross chain USD tests (#1634) * add transferCrossChain tests * refund leftover gas and test cleanup * create CrossChainUSDModule * fix lint * update transferCrossChain (#1650) * fix sol lint and revert deps change * fixes * run yarn * Use EVMTokenAmount amount * decouple from xchain-pools branch * revert unnecessary changes * remove more unnecessary files * Update storage dump * fix lint * fix deps * fix lint: use safe cast in utils module * implement feedback * update comment * revert version changes --------- Co-authored-by: Daniel Beal <git@danb.email> Co-authored-by: Daniel Beal <git@dbeal.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested by CCIP for testing purposes with their token pools.