🚀 Andromeda #89
Merged
🚀 Andromeda #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing parameter * lint * fix
noisekit
reviewed
Dec 8, 2023
noisekit
reviewed
Dec 8, 2023
| source = "mintable-token" | ||
| targetPreset = "<%= settings.target_preset %>" | ||
| options.salt = "<%= settings.salt %>" | ||
| source = "mintable-token:1.3" |
There was a problem hiding this comment.
Need to use 1.7 and decimals 6
Suggested change
| source = "mintable-token:1.3" | |
| source = "mintable-token:1.7" | |
| options.decimals = "6" |
There was a problem hiding this comment.
This was deployed as is though? I don't think we should change it if that's the case.
There was a problem hiding this comment.
We need to have fUSDC to have same decimals as real usdc because all the tests and potentially integrators implementations assume 18 decimals. Which will be a problem when we deploy to mainnet. We need to have a testnet deploy that is close to mainnet to avoid such issues
noisekit
reviewed
Dec 8, 2023
* Add mining, debt burning, and sUSD swapping in Ethereum end-to-end testing New functionalities are implemented to enrich the capabilities of Ethereum end-to-end testing. These include the addition of block mining, debt burning, and swapping to sUSD. The changes also extend the tasks in the Liquidity Provider e2e test, including elements such as account creation and sUSD deposit, thereby boosting the robustness and coverage of the testing script. * Add functionality to undelegate collateral
* base mainnet andromeda setup * pretty * limit to $50k LP and $10k OI as updated SIP-348 * added some todos * mainnet changes * fix url * fix include order * fixes * fixes * build success * deniers * susdc override * fix * remove susdc from deduction * update parameters * update settlement delay * fixes --------- Co-authored-by: cavalier_eth <91091124+cavalier-eth@users.noreply.github.com> Co-authored-by: Noah Litvin <335975+noahlitvin@users.noreply.github.com> Co-authored-by: kaleb <kalebkeny@gmail.com>
cc6340c to
f52f07f
Compare
noisekit
reviewed
Dec 13, 2023
| defaultValue = "0.0005" | ||
|
|
||
| [setting.perpsEthEndorsedLiquidator] | ||
| defaultValue = "0x11233749514Ab8d00C0A5873DF7428b3db70030f" |
There was a problem hiding this comment.
This value is the same as testnet. If it should be - nevermind
noisekit
reviewed
Dec 13, 2023
| defaultValue = "0.0005" | ||
|
|
||
| [setting.perpsBtcEndorsedLiquidator] | ||
| defaultValue = "0x11233749514Ab8d00C0A5873DF7428b3db70030f" |
There was a problem hiding this comment.
Same comment here too: this value is the same as testnet. If it should be - nevermind then
2818f4c to
2132c6d
Compare
…b.com/Synthetixio/synthetix-deployments into add-referrer-and-other-items-to-perps
noisekit
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.