Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28d #168

Merged
merged 2 commits into from
Jan 24, 2025

28d

8c7a167
Select commit
Loading
Failed to load commit list.
Merged

28d #168

28d
8c7a167
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 24, 2025 in 0s

63.93% (-0.51%) compared to 32aa05f

View this Pull Request on Codecov

63.93% (-0.51%) compared to 32aa05f

Details

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.93%. Comparing base (32aa05f) to head (8c7a167).

Files with missing lines Patch % Lines
liquidity/lib/usePoolsList/usePoolsList.ts 50.00% 4 Missing ⚠️
liquidity/lib/useApr/useApr.ts 72.72% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   64.43%   63.93%   -0.51%     
==========================================
  Files         262      262              
  Lines        6493     6475      -18     
  Branches     2170     2169       -1     
==========================================
- Hits         4184     4140      -44     
- Misses       2309     2335      +26     
Files with missing lines Coverage Δ
liquidity/lib/Pools/PoolRow.tsx 79.66% <100.00%> (+5.66%) ⬆️
liquidity/lib/Pools/PoolsList.tsx 97.67% <100.00%> (ø)
liquidity/lib/Positions/PositionTableHeader.tsx 100.00% <ø> (ø)
liquidity/lib/Positions/PositionsList.tsx 91.89% <ø> (-0.61%) ⬇️
liquidity/lib/Positions/PositionsRow.tsx 61.01% <100.00%> (+3.60%) ⬆️
liquidity/lib/calculations/calculations.ts 100.00% <ø> (+68.18%) ⬆️
liquidity/lib/formatters/number.ts 45.45% <ø> (-11.69%) ⬇️
liquidity/ui/src/ManagePage.tsx 91.66% <100.00%> (+5.95%) ⬆️
liquidity/lib/useApr/useApr.ts 78.94% <72.72%> (-2.88%) ⬇️
liquidity/lib/usePoolsList/usePoolsList.ts 80.95% <50.00%> (-15.35%) ⬇️

... and 8 files with indirect coverage changes